FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TST: unbreak tests on FREEBSD by mattip · Pull Request #23684 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

TST: unbreak tests on FREEBSD - #23684

Closed
mattip wants to merge 5 commits into
python:masterfrom
mattip:unbreak
ConversationCommits (5)ChecksFiles changed
Closed

TST: unbreak tests on FREEBSD#23684
mattip wants to merge 5 commits into
python:masterfrom
mattip:unbreak

Conversation

mattip commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

In PR gh-22088 I added extended a test that FREEBSD is not happy with.

This should unbreak the build on FREEBSD. I don't know why the original PR did not trip this, perhaps the buildbot was not running? Once the build is unbroken, I would be happy to hear from FREEBSD people why the test failed, it should not.

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Dec 7, 2020

fochoao commented Dec 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Add it on a Tuple ir List.

vstinner commented Dec 8, 2020

Copy link
Copy Markdown
Member

Well, I would prefer to fix the issue that skipping it. Otherwise, there is a risk of forgetting this bug.

vstinner commented Dec 8, 2020

Copy link
Copy Markdown
Member

It is ok is FreeBSD and AIX buildbots are broken for a few days.

mattip commented Dec 8, 2020

Copy link
Copy Markdown
Contributor Author

Closing in favor of fixing the problem in gh-23708

mattip closed this Dec 8, 2020

fochoao commented Dec 29, 2020

Copy link
Copy Markdown

The code can be made with a function with tuples or lists, instead of writing the same 5 or 6 times.

I can do this though, if You want this tell me.

mattip commented Dec 29, 2020

Copy link
Copy Markdown
Contributor Author

@fochoao what do you mean? I see this comment from 22 days ago as well. Can you be more specific: which function?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL