FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42598: Fix implicit function declarations in configure by jmroot · Pull Request #23690 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-42598: Fix implicit function declarations in configure - #23690

Merged
ned-deily merged 3 commits into
python:masterfrom
jmroot:configure-implicit-declaration
Dec 13, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-42598: Fix implicit function declarations in configure#23690
ned-deily merged 3 commits into
python:masterfrom
jmroot:configure-implicit-declaration

Conversation

jmroot commented Dec 8, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This is invalid in C99 and later and is an error with some compilers
(e.g. clang in Xcode 12), and can thus cause configure checks to
produce incorrect results.

Rather than including stdlib.h for the exit calls, I just changed them to return since they are all in main() anyway.

https://bugs.python.org/issue42598

Fix implicit function declarations in configure
04fdb6c 
This is invalid in C99 and later and is an error with some compilers
(e.g. clang in Xcode 12), and can thus cause configure checks to
produce incorrect results.
ned-deily approved these changes Dec 13, 2020
View reviewed changes

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

ned-deily merged commit 674fa0a into python:master Dec 13, 2020

miss-islington commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

Thanks @jmroot for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

bedevere-bot commented Dec 13, 2020

Copy link
Copy Markdown

GH-23756 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 13, 2020
bpo-42598: Fix implicit function declarations in configure (pythonGH-…
031bcb5 
…23690)

This is invalid in C99 and later and is an error with some compilers
(e.g. clang in Xcode 12), and can thus cause configure checks to
produce incorrect results.
(cherry picked from commit 674fa0a)

Co-authored-by: Joshua Root <jmr@macports.org>

bedevere-bot commented Dec 13, 2020

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x has failed when building commit 674fa0a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/442/builds/853) and take a look at the build logs.
  4. Check if the failure is related to this commit (674fa0a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/442/builds/853

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

410 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 45 sec
  • test_multiprocessing_spawn: 1 min 9 sec
  • test_multiprocessing_forkserver: 57.4 sec
  • test_multiprocessing_fork: 52.3 sec
  • test_signal: 47.8 sec
  • test_asyncio: 45.5 sec
  • test_io: 33.6 sec
  • test_imaplib: 32.9 sec
  • test_pydoc: 31.1 sec
  • test_socket: 29.2 sec

1 test altered the execution environment:
test_asyncio

15 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 3 min 43 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/base_events.py", line 745, in call_soon
    self._check_closed()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

ned-deily commented Dec 13, 2020

Copy link
Copy Markdown
Member

Re buildbot failure above: I compared the results of this run (853) on the buildbot to the previous run (852) and didn't see any obvious differences other than the test_asyncio environment changed warning. Since test_asyncio is known to be finicky, I am going to ignore this failure for now.

miss-islington commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

Thanks @jmroot for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot commented Dec 13, 2020

Copy link
Copy Markdown

GH-23757 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 13, 2020
bpo-42598: Fix implicit function declarations in configure (pythonGH-…
8214c68 
…23690)

This is invalid in C99 and later and is an error with some compilers
(e.g. clang in Xcode 12), and can thus cause configure checks to
produce incorrect results.
(cherry picked from commit 674fa0a)

Co-authored-by: Joshua Root <jmr@macports.org>
ned-deily pushed a commit that referenced this pull request Dec 13, 2020
bpo-42598: Fix implicit function declarations in configure (GH-23690) (…
3dcdbde 
…GH-23756)

This is invalid in C99 and later and is an error with some compilers
(e.g. clang in Xcode 12), and can thus cause configure checks to
produce incorrect results.
(cherry picked from commit 674fa0a)

Co-authored-by: Joshua Root <jmr@macports.org>
ned-deily pushed a commit that referenced this pull request Dec 13, 2020
bpo-42598: Fix implicit function declarations in configure (GH-23690) (…
9feda9f 
…GH-23757)

This is invalid in C99 and later and is an error with some compilers
(e.g. clang in Xcode 12), and can thus cause configure checks to
produce incorrect results.
(cherry picked from commit 674fa0a)

Co-authored-by: Joshua Root <jmr@macports.org>
jmroot deleted the configure-implicit-declaration branch December 13, 2020 23:05
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-42598: Fix implicit function declarations in configure (pythonGH-…
0bc60b8 
…23690)

This is invalid in C99 and later and is an error with some compilers
(e.g. clang in Xcode 12), and can thus cause configure checks to
produce incorrect results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL