[Enum] reformat and add doc strings by ethanfurman · Pull Request #23705 · python/cpython · GitHub

No description provided.

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

Sorry, @ethanfurman, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6d3dfee271b6e4afbfb060c269b034b871e2d1b3 3.8

Sorry @ethanfurman, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6d3dfee271b6e4afbfb060c269b034b871e2d1b3 3.9

GH-23706 is a backport of this pull request to the 3.8 branch.

(cherry picked from commit 6d3dfee) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

GH-23707 is a backport of this pull request to the 3.9 branch.

* [3.8] [Enum] reformat and add doc strings (GH-23705).

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO 3.8 has failed when building commit 21ca80e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/383/builds/134) and take a look at the build logs.
Check if the failure is related to this commit (21ca80e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/383/builds/134

Failed tests:

test_nntplib

Failed subtests:

test_with_statement - test.test_nntplib.NetworkedNNTP_SSLTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

409 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 38 sec
test_multiprocessing_spawn: 1 min 58 sec
test_tokenize: 1 min 34 sec
test_multiprocessing_forkserver: 1 min 33 sec
test_multiprocessing_fork: 1 min 17 sec
test_lib2to3: 1 min 8 sec
test_tools: 59.2 sec
test_asyncio: 54.9 sec
test_io: 39.3 sec
test_subprocess: 36.2 sec

1 test failed:
test_nntplib

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_nntplib

Total duration: 5 min 39 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 273, in test_with_statement
    with self.NNTP_CLASS(self.NNTP_HOST, timeout=TIMEOUT, usenetrc=False) as server:
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 1081, in __init__
    self.sock = _encrypt_on(self.sock, ssl_context, host)
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 293, in _encrypt_on
    return context.wrap_socket(sock, server_hostname=hostname)
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 500, in wrap_socket
    return self.sslsocket_class._create(
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 1040, in _create
    self.do_handshake()
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 1309, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1125)


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 283, in test_with_statement
    if re.search(r'(?i)KEY.TOO.SMALL', ssl_err.reason):
  File "/home/dje/cpython-buildarea/3.8.edelsohn-rhel-z.lto/build/Lib/re.py", line 201, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object

* [3.9] [Enum] reformat and add doc strings (GH-23705).

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO 3.9 has failed when building commit 4b37228.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/8/builds/196) and take a look at the build logs.
Check if the failure is related to this commit (4b37228) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/8/builds/196

Failed tests:

test_nntplib

Failed subtests:

test_with_statement - test.test_nntplib.NetworkedNNTP_SSLTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

411 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 11 sec
test_peg_generator: 2 min 53 sec
test_tokenize: 1 min 50 sec
test_multiprocessing_spawn: 1 min 41 sec
test_lib2to3: 1 min 17 sec
test_multiprocessing_forkserver: 1 min 13 sec
test_asyncio: 1 min 11 sec
test_unparse: 1 min 7 sec
test_multiprocessing_fork: 59.0 sec
test_signal: 48.6 sec

1 test failed:
test_nntplib

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_nntplib

Total duration: 6 min 53 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 277, in test_with_statement
    server = self.NNTP_CLASS(self.NNTP_HOST,
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 1025, in __init__
    super().__init__(host, port, user, password, readermode,
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 334, in __init__
    self.sock = self._create_socket(timeout)
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 1031, in _create_socket
    sock = _encrypt_on(sock, self.ssl_context, self.host)
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 292, in _encrypt_on
    return context.wrap_socket(sock, server_hostname=hostname)
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 500, in wrap_socket
    return self.sslsocket_class._create(
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 1040, in _create
    self.do_handshake()
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 1309, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1123)


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 293, in test_with_statement
    if re.search(r'(?i)KEY.TOO.SMALL', ssl_err.reason):
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto/build/Lib/re.py", line 201, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO + PGO 3.9 has failed when building commit 4b37228.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/211/builds/191) and take a look at the build logs.
Check if the failure is related to this commit (4b37228) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/211/builds/191

Failed tests:

test_nntplib

Failed subtests:

test_with_statement - test.test_nntplib.NetworkedNNTP_SSLTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

410 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 10 sec
test_tokenize: 1 min 46 sec
test_multiprocessing_spawn: 1 min 31 sec
test_unparse: 1 min 24 sec
test_multiprocessing_forkserver: 1 min 13 sec
test_asyncio: 1 min 13 sec
test_lib2to3: 1 min 5 sec
test_multiprocessing_fork: 57.8 sec
test_signal: 48.7 sec
test_io: 45.4 sec

1 test failed:
test_nntplib

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_nntplib

Total duration: 5 min 43 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_nntplib.py", line 277, in test_with_statement
    server = self.NNTP_CLASS(self.NNTP_HOST,
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/nntplib.py", line 1025, in __init__
    super().__init__(host, port, user, password, readermode,
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/nntplib.py", line 334, in __init__
    self.sock = self._create_socket(timeout)
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/nntplib.py", line 1031, in _create_socket
    sock = _encrypt_on(sock, self.ssl_context, self.host)
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/nntplib.py", line 292, in _encrypt_on
    return context.wrap_socket(sock, server_hostname=hostname)
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/ssl.py", line 500, in wrap_socket
    return self.sslsocket_class._create(
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/ssl.py", line 1040, in _create
    self.do_handshake()
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/ssl.py", line 1309, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1123)


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_nntplib.py", line 293, in test_with_statement
    if re.search(r'(?i)KEY.TOO.SMALL', ssl_err.reason):
  File "/home/dje/cpython-buildarea/3.9.edelsohn-rhel-z.lto-pgo/build/Lib/re.py", line 201, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object

reformat and add doc strings

bc87c52

the-knights-who-say-ni added the CLA signed label Dec 8, 2020

bedevere-bot added the awaiting core review label Dec 8, 2020

ethanfurman self-assigned this Dec 8, 2020

ethanfurman added skip issue skip news labels Dec 8, 2020

ethanfurman merged commit 6d3dfee into python:master Dec 8, 2020

bedevere-bot removed the awaiting core review label Dec 8, 2020

ethanfurman added needs backport to 3.8 labels Dec 8, 2020

bedevere-bot removed the needs backport to 3.8 label Dec 8, 2020

ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Dec 8, 2020

[3.8] [Enum] reformat and add doc strings (pythonGH-23705 ).

423f28d

(cherry picked from commit 6d3dfee) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Dec 8, 2020

[3.9] [Enum] reformat and add doc strings (pythonGH-23705 ).

0da3ad9

(cherry picked from commit 6d3dfee) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

bedevere-bot removed the needs backport to 3.9 label Dec 8, 2020

ethanfurman added a commit that referenced this pull request Dec 8, 2020

[3.8] [Enum] reformat and add doc strings (GH-23705 ). (GH-23706 )

21ca80e

* [3.8] [Enum] reformat and add doc strings (GH-23705).

ethanfurman added a commit that referenced this pull request Dec 8, 2020

[3.9] [Enum] reformat and add doc strings (GH-23705 ). (GH-23707 )

4b37228

* [3.9] [Enum] reformat and add doc strings (GH-23705).

ethanfurman deleted the enum-reformat branch December 9, 2020 00:22

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021

[Enum] reformat and add doc strings (pythonGH-23705 )

b2ade63

[Enum] reformat and add doc strings by ethanfurman · Pull Request #23705 · python/cpython · GitHub

Repository navigation

[Enum] reformat and add doc strings - #23705

[Enum] reformat and add doc strings#23705
ethanfurman merged 1 commit into
python:masterfrom
ethanfurman:enum-reformat

ethanfurman commented Dec 8, 2020

Uh oh!

miss-islington commented Dec 8, 2020

Uh oh!

miss-islington commented Dec 8, 2020

Uh oh!

miss-islington commented Dec 8, 2020

Uh oh!

miss-islington commented Dec 8, 2020

Uh oh!

bedevere-bot commented Dec 8, 2020

Uh oh!

bedevere-bot commented Dec 8, 2020

Uh oh!

bedevere-bot commented Dec 8, 2020

Uh oh!

bedevere-bot commented Dec 8, 2020

Uh oh!

bedevere-bot commented Dec 8, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Enum] reformat and add doc strings by ethanfurman · Pull Request #23705 · python/cpython · GitHub

Repository navigation

[Enum] reformat and add doc strings - #23705

[Enum] reformat and add doc strings#23705ethanfurman merged 1 commit intopython:masterpython/cpython:masterfrom ethanfurman:enum-reformatethanfurman/cpython:enum-reformatCopy head branch name to clipboard

Conversation

ethanfurman commented Dec 8, 2020

Uh oh!

miss-islington commented Dec 8, 2020

Uh oh!

miss-islington commented Dec 8, 2020

Uh oh!

miss-islington commented Dec 8, 2020

Uh oh!

miss-islington commented Dec 8, 2020

Uh oh!

bedevere-bot commented Dec 8, 2020

Uh oh!

bedevere-bot commented Dec 8, 2020

Uh oh!

bedevere-bot commented Dec 8, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 8, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 8, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Enum] reformat and add doc strings#23705
ethanfurman merged 1 commit into
python:masterfrom
ethanfurman:enum-reformat