| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
Follow-up: PEP 594 has been accepted and these modules are set for removal in 3.12. Relevant issues:
Merged documentation PRs:
I expect 3.12 will open for development in about a month when 3.11 reaches beta. |
Sorry, something went wrong.
|
Closing as out of date. This PR was superseded by #72719 (which was reverted and will not be superseded by yet a new one). |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
As per PEP 594, this PR removes asyncore, asynchat, and smptd. This includes any documentation, tests, and source code, except for parts that were needed for existing tests. Those were moved to Lib/test/support/<module>, and the essential parts were determined through usage of coverage.py. After I removed test_<module>, I looked to see which members were utilized in the existing tests, and removed any that were not used. I did not do any partial removals though; e.g. specific unused branches within a member that is otherwise used. I also left unused __repr__ for debugging purposes.
For improved communication and convenience to users, importing any of the 3 removed modules after these changes results in the following:
This could potentially be removed in couple versions if needed, but since it imposes no real maintenance burden I think we can leave the custom ImportError indefinitely. The only change would possibly be updating tiran/legacylib to python/legacylib, assuming it is eventually moved there.
https://bugs.python.org/issue42611