FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib by aeros · Pull Request #23728 · python/cpython · GitHub

/ cpython Public

bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib - #23728

Closed
aeros wants to merge 5 commits into
python:mainfrom
aeros:remove-asycore-asynchat-smtpd
Closed

bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib#23728
aeros wants to merge 5 commits into
python:mainfrom
aeros:remove-asycore-asynchat-smtpd

Conversation

aeros commented Dec 10, 2020
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

As per PEP 594, this PR removes asyncore, asynchat, and smptd. This includes any documentation, tests, and source code, except for parts that were needed for existing tests. Those were moved to Lib/test/support/<module>, and the essential parts were determined through usage of coverage.py. After I removed test_<module>, I looked to see which members were utilized in the existing tests, and removed any that were not used. I did not do any partial removals though; e.g. specific unused branches within a member that is otherwise used. I also left unused __repr__ for debugging purposes.

For improved communication and convenience to users, importing any of the 3 removed modules after these changes results in the following:

raise ImportError(
    "As of 3.10, <module> has been removed from the standard library, see "
    "PEP 594 for details. An archived (no longer maintained) version exists "
    "at https://github.com/tiran/legacylib"
)

This could potentially be removed in couple versions if needed, but since it imposes no real maintenance burden I think we can leave the custom ImportError indefinitely. The only change would possibly be updating tiran/legacylib to python/legacylib, assuming it is eventually moved there.

https://bugs.python.org/issue42611

aeros requested a review from tiran December 10, 2020 04:40
aeros changed the title PEP 594 - Remove asyncore, asynchat, and smptd from stdlib bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib Dec 10, 2020
aeros removed the skip issue label Dec 10, 2020
aeros marked this pull request as ready for review December 10, 2020 05:52
aeros requested review from a team and vsajip as code owners December 10, 2020 05:52
aeros removed request for a team and vsajip December 10, 2020 06:22

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 18, 2021
tiran removed their request for review December 7, 2021 12:07

hugovk commented Apr 11, 2022
edited
Loading

Copy link
Copy Markdown
Member

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 2, 2022

Copy link
Copy Markdown
Member

Closing as out of date.

This PR was superseded by #72719 (which was reverted and will not be superseded by yet a new one).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL