FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-42195: Ensure consistency of Callable's __args__ in collections.abc and typing (GH-23060) by Fidget-Spinner · Pull Request #23765 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.9] bpo-42195: Ensure consistency of Callable's __args__ in collections.abc and typing (GH-23060) - #23765

Merged
gvanrossum merged 2 commits into
python:3.9from
Fidget-Spinner:3.9-abc-callable-ga
Dec 14, 2020
ConversationCommits (2)ChecksFiles changed
Merged

[3.9] bpo-42195: Ensure consistency of Callable's __args__ in collections.abc and typing (GH-23060)#23765
gvanrossum merged 2 commits into
python:3.9from
Fidget-Spinner:3.9-abc-callable-ga

Conversation

Fidget-Spinner commented Dec 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This patch fixes bpo-42195 via changing the GenericAlias builtin and subclassing for collections.abc.Callable's __class_getitem__. The changes are:

  1. Made GenericAlias subclassable.
  2. Subclassed it in collections.abc.Callable's __class_getitem__ to allow for consistentency with typing.Callable's __args__. This includes flattening the __args__.
>>> import collections.abc
>>> alias = collections.abc.Callable[[int, str], dict]

>>> alias
collections.abc.Callable[[int, str], dict]

>>> alias.__args__
(int, str, dict)
  1. Added tests for the above.
  2. Loosened type checks for Callable's argtypes in Callable[[argtypes], resulttype] to prepare for PEP 612.

https://bugs.python.org/issue42195

(cherry picked from commit 463c7d3)

gvanrossum approved these changes Dec 14, 2020
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! Just what I had in mind.

bedevere-bot commented Dec 14, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

gvanrossum commented Dec 14, 2020

Copy link
Copy Markdown
Member

I don't understand why you get test failures for test_ttk_guionly, but I don't think it's your fault. Possibly it'll pass now the tests are bein rerun.

gvanrossum merged commit 33b3fed into python:3.9 Dec 14, 2020
Fidget-Spinner deleted the 3.9-abc-callable-ga branch December 18, 2020 14:12
edmorley mentioned this pull request Oct 21, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
ilevkivskyi Awaiting requested review from ilevkivskyi
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL