FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-86819: Add ISO-TP CAN socket constants by rumpelsepp · Pull Request #23794 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-86819: Add ISO-TP CAN socket constants - #23794

Merged
erlend-aasland merged 3 commits into
python:mainfrom
rumpelsepp:isotp
Sep 17, 2025
ConversationCommits (3)ChecksFiles changed
Merged

gh-86819: Add ISO-TP CAN socket constants#23794
erlend-aasland merged 3 commits into
python:mainfrom
rumpelsepp:isotp

Conversation

rumpelsepp commented Dec 16, 2020 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This adds constants to the socket module which are provided by the new isotp module available in Linux >= 5.10.

https://bugs.python.org/issue42653
#86819

the-knights-who-say-ni commented Dec 16, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rumpelsepp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

shawnl commented Dec 16, 2020 •
edited
Loading

Copy link
Copy Markdown

As the reporter or the original feature request this patch looks good to me.

(Although I hate autoconf magic)

rumpelsepp commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

(Although I hate autoconf magic)

As do I… Is there anything else I have to adjust here? My autoreconf version seems different and it mutilates the checked in configure script.

vstinner commented Dec 16, 2020

Copy link
Copy Markdown
Member

Please open a new issue: https://bugs.python.org/issue10141 is closed.

rumpelsepp changed the title bpo-10141: Add constants for isotp.h which is included in Linux >= 5.10 issue42653: Add constants for isotp.h which is included in Linux >= 5.10 Dec 16, 2020
rumpelsepp changed the title issue42653: Add constants for isotp.h which is included in Linux >= 5.10 bpo-42653: Add constants for isotp.h which is included in Linux >= 5.10 Dec 16, 2020

rumpelsepp commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

done

tiran previously requested changes Dec 16, 2020
View reviewed changes

tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please include a blurb and leave the CAN_ISOTP macro in place.

Comment thread Modules/socketmodule.c Outdated

bedevere-bot commented Dec 16, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

rumpelsepp commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Dec 16, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

bedevere-bot requested a review from tiran December 16, 2020 09:30

github-actions Bot commented Jan 16, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
tiran removed their request for review April 17, 2021 21:16

rumpelsepp commented May 5, 2021

Copy link
Copy Markdown
Contributor Author

Am I supposed to do any more changes here?

ghost mentioned this pull request May 19, 2021
Closed
rumpelsepp force-pushed the isotp branch 4 times, most recently from c287165 to 0c4ed7d Compare February 28, 2022 23:47
erlend-aasland dismissed tiran’s stale review October 14, 2024 22:12

Christian's concerns were addressed: a NEWS blurb was added, and the CAN_ISOTP macro was left in place.

erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024

bedevere-bot commented Oct 14, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ffae37c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024

picnixz commented Aug 22, 2025

Copy link
Copy Markdown
Member

Could you move the what's new entry to 3.15.rst instead?

rumpelsepp requested a review from AA-Turner as a code owner August 22, 2025 09:48

picnixz commented Aug 22, 2025

Copy link
Copy Markdown
Member

Don't forget to re-add the NEWS entry (I don't know where it disppeared)

rumpelsepp commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

Your comments should be addressed now.

picnixz reviewed Aug 22, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
picnixz reviewed Aug 22, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
picnixz reviewed Aug 22, 2025
View reviewed changes
Comment thread Lib/test/test_socket.py Outdated
Comment thread Misc/NEWS.d/next/Library/2025-08-22-09-53-45.gh-issue-86819.ECxvwx.rst Outdated
rumpelsepp force-pushed the isotp branch 3 times, most recently from 3508d7e to 7fb109b Compare August 22, 2025 10:02
Patrick Menschel and others added 2 commits August 22, 2025 12:03

rumpelsepp commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz Thank you for your review. I think I have catched up with your remarks.

erlend-aasland enabled auto-merge (squash) September 17, 2025 16:54
erlend-aasland linked an issue Sep 17, 2025 that may be closed by this pull request
Expose ISO-TP Contants for Linux >= 5.10 #86819
Closed
erlend-aasland merged commit a9b6b09 into python:main Sep 17, 2025
45 checks passed
rumpelsepp mannequin mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes
erlend-aasland erlend-aasland approved these changes
tiran Awaiting requested review from tiran
corona10 Awaiting requested review from corona10 corona10 is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose ISO-TP Contants for Linux >= 5.10

9 participants

Back | FazBrowse Home | New Git URL