bpo-42246: Make sure that f_lasti, and thus f_lineno, is set correctly after raising or reraising an exception - #23803
Merged
markshannon merged 3 commits intoDec 17, 2020
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…ectly after raising or reraising an exception (pythonGH-23803) * Ensure that f_lasti is set correctly after an exception is raised to conform to PEP 626. * Update importlib * Add NEWS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 626 requires that f_lineno always contains the last line executed.
This PR makes sure that is true, even after an exception is raised.
This is, hopefully, the last step in the rather-more-work-than-I-expected implementation of PEP 626.
https://bugs.python.org/issue42246