FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658) by andresdelfino · Pull Request #23827 · python/cpython · GitHub

/ cpython Public

[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658) - #23827

Merged
miss-islington merged 1 commit into
python:3.9from
andresdelfino:backport-dcc997c-3.9
Dec 22, 2020
ConversationCommits (1)ChecksFiles changed
Merged

[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)#23827
miss-islington merged 1 commit into
python:3.9from
andresdelfino:backport-dcc997c-3.9

Conversation

andresdelfino commented Dec 17, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..
(cherry picked from commit dcc997c)

Co-authored-by: Andre Delfino adelfino@gmail.com

Automerge-Triggered-By: GH:Mariatta

[3.9] [doc] Fix erroneous backslashes in signatures and names (python…
45075c2 
…GH-23658)

The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..
(cherry picked from commit dcc997c)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
bedevere-bot mentioned this pull request Dec 17, 2020
Merged

andresdelfino commented Dec 21, 2020

Copy link
Copy Markdown
Contributor Author

@Mariatta perhaps we can merge this?

ghost approved these changes Dec 22, 2020
View reviewed changes

ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Mariatta approved these changes Dec 22, 2020
View reviewed changes

Mariatta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

miss-islington merged commit e89993c into python:3.9 Dec 22, 2020

JulienPalard commented Jan 3, 2021

Copy link
Copy Markdown
Member

As in the 3.8 and 3.9 branch we don't use the newer Sphinx, this commit drops the backslashes :( I think this should be reverted, are you ok for a revert @andresdelfino ?

JulienPalard mentioned this pull request Jan 3, 2021
Closed
andresdelfino deleted the backport-dcc997c-3.9 branch January 3, 2021 13:21

andresdelfino commented Jan 3, 2021

Copy link
Copy Markdown
Contributor Author

@JulienPalard this commit doesn't affect how the doc is rendered for 3.8/3.9, but I think it's good to have consistency with master (to prevent conflicts for future commits).

JulienPalard mentioned this pull request Jan 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Mariatta Mariatta approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL