Repository navigation
[3.9] bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708) - #23866
Merged
pablogsal merged 1 commit intoDec 20, 2020
Merged
[3.9] bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708)#23866pablogsal merged 1 commit into
pablogsal merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…onfigure (pythonGH-23708) Now all platforms use a value for the "EXT_SUFFIX" build variable derived from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so" instead of ".so"). Previously only Linux, Mac and VxWorks were using a value for "EXT_SUFFIX" that included "SOABI". Co-authored-by: Pablo Galindo <pablogsal@gmail.com> (cherry picked from commit a44ce6c) Co-authored-by: Matti Picus <matti.picus@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
@mattip and @pablogsal: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
pablogsal
approved these changes
Dec 20, 2020
Copy link
Copy Markdown
Contributor
Author
|
@mattip and @pablogsal: Status check is done, and it's a failure ❌ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I don’t think this failure is connected to the change ======================================================================
FAIL: test_heading_callback (tkinter.test.test_ttk.test_widgets.TreeviewTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1548, in test_heading_callback
simulate_heading_click(5, 5)
File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1536, in simulate_heading_click
self.assertEqual(self.tv.identify_region(x, y), 'heading')
AssertionError: 'nothing' != 'heading'
- nothing
+ heading
======================================================================
FAIL: test_variable_change (tkinter.test.test_ttk.test_extensions.LabeledScaleTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_extensions.py", line 144, in test_variable_change
self.assertGreater(x.scale.coords()[0], curr_xcoord)
AssertionError: 1 not greater than 1
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Yep, that is some unrelated tkinter failure |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".
Co-authored-by: Pablo Galindo pablogsal@gmail.com
(cherry picked from commit a44ce6c)
Co-authored-by: Matti Picus matti.picus@gmail.com
https://bugs.python.org/issue42604