| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Add Include/cpython/pytime.h header file. Move CPython C API from Include/pytime.h into a new Include/cpython/pytime.h header file, which is included by Include/pytime.h.
|
Hmm, I'd like to add the skip-news label like previous PRs for this issue, but can't seem to do this. Help? |
Sorry, something went wrong.
|
Hum, since the new Include/pytime.h is basically empty. I suggest to leave the file unchanged and the move it into Include/cpython/. I don't expect anyone to include it directly, and it's already included by "Python.h". The C API documentation asks to only include "Python.h." |
Sorry, something went wrong.
Address review; replaced by Include/cpython/pytime.h
| #include "pycore_pyerrors.h" | ||
| #include "pycore_pystate.h" // _PyThreadState_GET() | ||
| #include "pydtrace.h" | ||
| #include "pytime.h" // _PyTime_GetMonotonicClock() |
There was a problem hiding this comment.
Hum. Since it's included by Python.h, including it explicitly is not needed, no?
Sorry, something went wrong.
There was a problem hiding this comment.
I've updated these, and moved the pytime.h include further down in Python.h to allow for it. I believe there aren't any other files including pytime.h directly now.
Sorry, something went wrong.
|
|
||
| #include "pyconfig.h" /* include for defines */ | ||
| #include "object.h" | ||
| #include "../object.h" |
There was a problem hiding this comment.
I don't think that people should include pytime.h directly, and so I suggest to simply remove these includes. Let people respect the Python C API documentation which suggests to only include "Python.h".
Sorry, something went wrong.
|
Thank you, I merged your PR. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot PPC64LE RHEL8 LTO 3.x has failed when building commit 17dbd40. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/361/builds/1230 Summary of the results of the build (if available): == Tests result: ENV CHANGED == 412 tests OK. 10 slowest tests:
1 test altered the execution environment: 13 tests skipped: Total duration: 5 min 42 sec Click to see traceback logsTraceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 321, in __del__
self.close()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 316, in close
self._ssl_protocol._start_shutdown()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
self._abort()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 731, in _abort
self._transport.abort()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/selector_events.py", line 680, in abort
self._force_close(None)
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/selector_events.py", line 731, in _force_close
self._loop.call_soon(self._call_connection_lost, exc)
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 745, in call_soon
self._check_closed()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 510, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
|
Sorry, something went wrong.
This change is backward compatible since C extension modules must not include "pytime.h" directly, but only include "Python.h".
| Back | FazBrowse Home | New Git URL |
Add Include/cpython/pytime.h header file.
Move CPython C API from Include/pytime.h into a new
Include/cpython/pytime.h header file, which is included by
Include/pytime.h.
https://bugs.python.org/issue35134
In the same vein as previous PRs by @vstinner. I've never done this before, so apologies in advance if I've messed anything up.
https://bugs.python.org/issue35134