Repository navigation
[3.8] bpo-26407: Do not mask errors in csv. (GH-20536) - #24021
Merged
serhiy-storchaka merged 2 commits intoJan 1, 2021
Merged
serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Unexpected errors in calling the __iter__ method are no longer masked by TypeError in csv.reader(), csv.writer.writerow() and csv.writer.writerows().. (cherry picked from commit c88239f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
Member
|
GHA tests do not give an error report. Travis says failure (unrelated) in test_nntplib ERROR: test_descriptions (test.test_nntplib.NetworkedNNTP_SSLTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/python/cpython/Lib/test/test_nntplib.py", line 250, in wrapped
meth(self)
File "/home/travis/build/python/cpython/Lib/test/test_nntplib.py", line 99, in test_descriptions
desc = descs[self.GROUP_NAME]
KeyError: 'comp.lang.python'
======================================================================
FAIL: test_description (test.test_nntplib.NetworkedNNTP_SSLTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/python/cpython/Lib/test/test_nntplib.py", line 250, in wrapped
meth(self)
File "/home/travis/build/python/cpython/Lib/test/test_nntplib.py", line 85, in test_description
self.assertIn("Python", desc)
AssertionError: 'Python' not found in ''
Pipelines says more or less same including on Windows. I will rerun in case transient.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unexpected errors in calling the iter method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows().
(cherry picked from commit c88239f)
https://bugs.python.org/issue26407