FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" by JulienPalard · Pull Request #24093 · python/cpython · GitHub

/ cpython Public

[3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" - #24093

Merged
JulienPalard merged 1 commit into
3.8from
revert-23828-backport-dcc997c-3.8
Jan 4, 2021
ConversationCommits (1)ChecksFiles changed
Merged

[3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"#24093
JulienPalard merged 1 commit into
3.8from
revert-23828-backport-dcc997c-3.8

Conversation

JulienPalard commented Jan 4, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

JulienPalard requested review from a team, 1st1, asvetlov and gpshead as code owners January 4, 2021 12:35

JulienPalard commented Jan 4, 2021

Copy link
Copy Markdown
Member Author

Hum no, a full revert is not needed, only some bits has to be reverted, let me check this in details.

Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (…
bcacd9d 
…GH-23658)"

This partially reverts commit
02349e2, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
JulienPalard force-pushed the revert-23828-backport-dcc997c-3.8 branch from 43bcae7 to bcacd9d Compare January 4, 2021 12:51

JulienPalard commented Jan 4, 2021

Copy link
Copy Markdown
Member Author

@andresdelfino Same here, I kept only backslashes involved in strings, so in one hand we keep the difference as small as possible between versions (easing backports), while keeping the doc right.

I hope I picked the right ones, I still did not took the time to build it locally to visually check every change (I'm at $DAYJOB lunch break ;p).

JulienPalard changed the title Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" Jan 4, 2021
JulienPalard added skip news docs Documentation in the Doc dir labels Jan 4, 2021
JulienPalard changed the title bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" [3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" Jan 4, 2021
andresdelfino approved these changes Jan 4, 2021
View reviewed changes

andresdelfino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

andresdelfino commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

@JulienPalard I compared your changes with the ones introduced and found all of the problematic ones fixed :)

JulienPalard merged commit 218ed0b into 3.8 Jan 4, 2021
JulienPalard deleted the revert-23828-backport-dcc997c-3.8 branch January 4, 2021 16:19
JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Jan 21, 2021
Revert "[doc] Fix erroneous backslashes in signatures and names (pyth…
900251b 
…onGH-23658)" (pythonGH-24093)

This partially reverts commit
02349e2, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
gpshead Awaiting requested review from gpshead
1 more reviewer
andresdelfino andresdelfino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL