bpo-42811: Update importlib.utils.resolve_name() docs to use spec.parent by yairfrid · Pull Request #24100 · python/cpython · GitHub

https://bugs.python.org/issue42811

Automerge-Triggered-By: GH:brettcannon

…_name

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Fongeme

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Use __spec__.parent instead of __spec__ Co-authored-by: Brett Cannon <brett@python.org>

…Y2beA.rst According to last commit Co-authored-by: Brett Cannon <brett@python.org>

I have made the requested changes; please review again

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

Thanks @Fongeme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

Sorry @Fongeme, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ff8458b918050168acda1ad6d079f52b8effa821 3.9

GH-24144 is a backport of this pull request to the 3.8 branch.

….parent (pythonGH-24100) Automerge-Triggered-By: GH:brettcannon (cherry picked from commit ff8458b) Co-authored-by: Yair Frid <fridyair@gmail.com>

…spec__.parent (pythonGH-24100)

GH-24149 is a backport of this pull request to the 3.9 branch.

…spec__.parent (GH-24100) (GH-24149) This is a backport of #24100 Automerge-Triggered-By: GH:brettcannon

….parent (GH-24100) (GH-24144) Automerge-Triggered-By: GH:brettcannon (cherry picked from commit ff8458b) Co-authored-by: Yair Frid <fridyair@gmail.com>

….parent (pythonGH-24100) Automerge-Triggered-By: GH:brettcannon

Changed __package__ to __spec__ in example for importlib.utils.reolve…

0fba9cd

…_name

the-knights-who-say-ni added the CLA not signed label Jan 4, 2021

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 4, 2021

Added blurb

1101a14

brettcannon self-requested a review January 4, 2021 21:13

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jan 5, 2021

brettcannon requested changes Jan 6, 2021

View reviewed changes

Comment thread Doc/library/importlib.rst Outdated

Comment thread Misc/NEWS.d/next/Documentation/2021-01-04-22-14-22.bpo-42811.HY2beA.rst Outdated

bedevere-bot added awaiting changes and removed awaiting review labels Jan 6, 2021

yairfrid and others added 2 commits January 6, 2021 11:49

Update Doc/library/importlib.rst

1c017a6

Use __spec__.parent instead of __spec__ Co-authored-by: Brett Cannon <brett@python.org>

Update Misc/NEWS.d/next/Documentation/2021-01-04-22-14-22.bpo-42811.H…

723e86b

…Y2beA.rst According to last commit Co-authored-by: Brett Cannon <brett@python.org>

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 6, 2021

bedevere-bot requested a review from brettcannon January 6, 2021 09:50

brettcannon changed the title bpo-42811: Update importlib.utils.resolve_name docs bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent Jan 6, 2021

brettcannon added 🤖 automerge labels Jan 6, 2021

brettcannon approved these changes Jan 6, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jan 6, 2021

miss-islington merged commit ff8458b into python:master Jan 6, 2021

bedevere-bot removed the awaiting merge label Jan 6, 2021

miss-islington self-assigned this Jan 6, 2021

bedevere-bot removed the needs backport to 3.8 label Jan 6, 2021

yairfrid added a commit to yairfrid/cpython that referenced this pull request Jan 7, 2021

[3.9] bpo-42811: Update importlib.utils.resolve_name() docs to use __…

7fcf792

…spec__.parent (pythonGH-24100)

yairfrid mentioned this pull request Jan 7, 2021

[3.9] bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent (GH-24100) #24149

Merged

bedevere-bot removed the needs backport to 3.9 label Jan 7, 2021

miss-islington pushed a commit that referenced this pull request Jan 7, 2021

[3.9] bpo-42811 : Update importlib.utils.resolve_name() docs to use __…

8c3914a

…spec__.parent (GH-24100) (GH-24149) This is a backport of #24100 Automerge-Triggered-By: GH:brettcannon

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021

bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__…

ef62a7f

….parent (pythonGH-24100) Automerge-Triggered-By: GH:brettcannon

bpo-42811: Update importlib.utils.resolve_name() docs to use spec.parent by yairfrid · Pull Request #24100 · python/cpython · GitHub

Repository navigation

bpo-42811: Update importlib.utils.resolve_name() docs to use spec.parent - #24100

bpo-42811: Update importlib.utils.resolve_name() docs to use spec.parent#24100
miss-islington merged 4 commits into
python:masterfrom
yairfrid:Issue42811

yairfrid commented Jan 4, 2021 •
edited by miss-islington
Loading

Uh oh!

Uh oh!

the-knights-who-say-ni commented Jan 4, 2021

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jan 6, 2021

Uh oh!

yairfrid commented Jan 6, 2021

Uh oh!

bedevere-bot commented Jan 6, 2021

Uh oh!

miss-islington commented Jan 6, 2021

Uh oh!

miss-islington commented Jan 6, 2021

Uh oh!

bedevere-bot commented Jan 6, 2021

Uh oh!

bedevere-bot commented Jan 7, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent by yairfrid · Pull Request #24100 · python/cpython · GitHub

Repository navigation

bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent - #24100

bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent#24100miss-islington merged 4 commits intopython:masterpython/cpython:masterfrom yairfrid:Issue42811yairfrid/cpython:Issue42811Copy head branch name to clipboard

Conversation

yairfrid commented Jan 4, 2021 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Jan 4, 2021

CLA Missing

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jan 6, 2021

Uh oh!

yairfrid commented Jan 6, 2021

Uh oh!

bedevere-bot commented Jan 6, 2021

Uh oh!

miss-islington commented Jan 6, 2021

Uh oh!

miss-islington commented Jan 6, 2021

Uh oh!

bedevere-bot commented Jan 6, 2021

Uh oh!

bedevere-bot commented Jan 7, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bpo-42811: Update importlib.utils.resolve_name() docs to use spec.parent by yairfrid · Pull Request #24100 · python/cpython · GitHub

bpo-42811: Update importlib.utils.resolve_name() docs to use spec.parent - #24100

bpo-42811: Update importlib.utils.resolve_name() docs to use spec.parent#24100
miss-islington merged 4 commits into
python:masterfrom
yairfrid:Issue42811

yairfrid commented Jan 4, 2021 •
edited by miss-islington
Loading