FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-42681: Fix test_curses failures related to color pairs (GH-24089) by serhiy-storchaka · Pull Request #24113 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.9] bpo-42681: Fix test_curses failures related to color pairs (GH-24089) - #24113

Merged
serhiy-storchaka merged 1 commit into
python:3.9from
serhiy-storchaka:backport-59f9b4e-3.9
Jan 5, 2021
ConversationCommits (1)ChecksFiles changed
Merged

[3.9] bpo-42681: Fix test_curses failures related to color pairs (GH-24089)#24113
serhiy-storchaka merged 1 commit into
python:3.9from
serhiy-storchaka:backport-59f9b4e-3.9

Conversation

serhiy-storchaka commented Jan 5, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

On ncurses 6.1 pair numbers are limited by SHORT_MAX-1.

Improve error reporting and tests for color functions.
(cherry picked from commit 59f9b4e)

https://bugs.python.org/issue42681

[3.9] bpo-42681: Fix test_curses failures related to color pairs (pyt…
ad76ab2 
…honGH-24089)

On ncurses 6.1 pair numbers are limited by SHORT_MAX-1, even
with extended color support.

Improve error reporting and tests for color functions..
(cherry picked from commit 59f9b4e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.8 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 5, 2021

bedevere-bot commented Jan 5, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit ad76ab2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 5, 2021
bedevere-bot mentioned this pull request Jan 5, 2021
Merged
serhiy-storchaka merged commit 9b3a53a into python:3.9 Jan 5, 2021

miss-islington commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

serhiy-storchaka deleted the backport-59f9b4e-3.9 branch January 5, 2021 12:23

miss-islington commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9b3a53a8264d4c469a3f3d8c037e74c010be3e5c 3.8

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 5, 2021
[3.8] [3.9] bpo-42681: Fix test_curses failures related to color pairs (
6f06d08 
pythonGH-24089) (pythonGH-24113)

On ncurses 6.1 pair numbers are limited by SHORT_MAX-1.

Improve error reporting and tests for color functions.
(cherry picked from commit 59f9b4e)
(cherry picked from commit 9b3a53a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot commented Jan 5, 2021

Copy link
Copy Markdown

GH-24116 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit that referenced this pull request Jan 5, 2021
[3.8] [3.9] bpo-42681: Fix test_curses failures related to color pairs (
e2c847e 
GH-24089) (GH-24113) (GH-24116)

On ncurses 6.1 pair numbers are limited by SHORT_MAX-1.

Improve error reporting and tests for color functions.
(cherry picked from commit 59f9b4e)
(cherry picked from commit 9b3a53a)
serhiy-storchaka removed their assignment Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL