FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[doc] Fix addCleanupClass -> addClassCleanup typo by Conchylicultor · Pull Request #24194 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[doc] Fix addCleanupClass -> addClassCleanup typo - #24194

Merged
tirkarthi merged 2 commits into
python:masterfrom
Conchylicultor:patch-1
Jan 20, 2021
ConversationCommits (2)ChecksFiles changed
Merged

[doc] Fix addCleanupClass -> addClassCleanup typo#24194
tirkarthi merged 2 commits into
python:masterfrom
Conchylicultor:patch-1

Conversation

Conchylicultor commented Jan 11, 2021

Copy link
Copy Markdown
Contributor

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 11, 2021
tirkarthi reviewed Jan 12, 2021
View reviewed changes

tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess there is a similar typo of doCleanupsClass -> doClassCleanups in https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups

Conchylicultor changed the title [doc] Fix addCleanupClass -> addCleanupClass typo [doc] Fix addCleanupClass -> addClassCleanup typo Jan 12, 2021

Conchylicultor commented Jan 13, 2021

Copy link
Copy Markdown
Contributor Author

I guess there is a similar typo of doCleanupsClass -> doClassCleanups in https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups

Done

tirkarthi approved these changes Jan 20, 2021
View reviewed changes

tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks.

tirkarthi merged commit e0e398e into python:master Jan 20, 2021

miss-islington commented Jan 20, 2021

Copy link
Copy Markdown
Contributor

Thanks @Conchylicultor for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

bedevere-bot commented Jan 20, 2021

Copy link
Copy Markdown

GH-24267 is a backport of this pull request to the 3.9 branch.

bedevere-bot commented Jan 20, 2021

Copy link
Copy Markdown

GH-24268 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2021
Fix typos in unittest documentation (pythonGH-24194)
cc2852a 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2021
Fix typos in unittest documentation (pythonGH-24194)
997d777 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
miss-islington added a commit that referenced this pull request Jan 20, 2021
Fix typos in unittest documentation (GH-24194)
ebb2f26 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Fix typos in unittest documentation (pythonGH-24194)
c4837f1 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
miss-islington added a commit that referenced this pull request Mar 14, 2021
Fix typos in unittest documentation (GH-24194)
bb46c13 
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tirkarthi tirkarthi approved these changes
+1 more reviewer
ZackerySpytz ZackerySpytz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL