Repository navigation
[3.7] [3.8] bpo-42531: Teach importlib.resources.path to handle packages without __file__ (GH-23611) - #24229
Closed
miss-islington wants to merge 1 commit into
Closed
[3.7] [3.8] bpo-42531: Teach importlib.resources.path to handle packages without __file__ (GH-23611)#24229miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…thout __file__ (pythonGH-23611) Fixes [bpo-42531]() for Python 3.8. The issue also applies to 3.7. If this PR looks like it'll be accepted, I can cherry-pick it to the 3.7 branch and submit a follow-up PR. Automerge-Triggered-By: GH:jaraco (cherry picked from commit f08c664) Co-authored-by: William Schwartz <wkschwartz@gmail.com>
jaraco
approved these changes
Jan 16, 2021
Copy link
Copy Markdown
Contributor
Author
|
@wkschwartz: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I see 3.7 is in security fix only, so if you need to support Python 3.7 and need the fix, please use the importlib_resources backport. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [bpo-42531]() for Python 3.8.
The issue also applies to 3.7. If this PR looks like it'll be accepted, I can cherry-pick it to the 3.7 branch and submit a follow-up PR.
Automerge-Triggered-By: GH:jaraco
(cherry picked from commit f08c664)
Co-authored-by: William Schwartz wkschwartz@gmail.com
https://bugs.python.org/issue42531
Automerge-Triggered-By: GH:jaraco