FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42979: Check the import of datetime's capi succeeded or not in zoneinfo. by shihai1991 · Pull Request #24333 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-42979: Check the import of datetime's capi succeeded or not in zoneinfo. - #24333

Merged
vstinner merged 1 commit into
python:masterfrom
shihai1991:bpo_42979
Jan 27, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-42979: Check the import of datetime's capi succeeded or not in zoneinfo.#24333
vstinner merged 1 commit into
python:masterfrom
shihai1991:bpo_42979

Conversation

shihai1991 commented Jan 25, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

vstinner merged commit eeb701a into python:master Jan 27, 2021

miss-islington commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

bedevere-bot commented Jan 27, 2021

Copy link
Copy Markdown

GH-24351 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2021
bpo-42979: _zoneinfo exec function checks for PyDateTime_IMPORT failu…
3b778df 
…re (pythonGH-24333)

Importing datetime can fail.
(cherry picked from commit eeb701a)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
vstinner pushed a commit that referenced this pull request Jan 27, 2021
bpo-42979: _zoneinfo exec function checks for PyDateTime_IMPORT failu…
895591c 
…re (GH-24333) (GH-24351)

Importing datetime can fail.
(cherry picked from commit eeb701a)

Co-authored-by: Hai Shi <shihai1992@gmail.com>

Co-authored-by: Hai Shi <shihai1992@gmail.com>

shihai1991 commented Jan 27, 2021

Copy link
Copy Markdown
Member Author

Thanks victor for your merge ;)

pganssle commented Jan 27, 2021

Copy link
Copy Markdown
Member

@shihai1991 Any interest in also submitting a patch to the backport, or releasing this patch under an Apache license compatible with the backport's license?

shihai1991 commented Jan 27, 2021

Copy link
Copy Markdown
Member Author

@shihai1991 Any interest in also submitting a patch to the backport, or releasing this patch under an Apache license compatible with the backport's license?

Done ; ). The new PR in: pganssle/zoneinfo#98

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-42979: _zoneinfo exec function checks for PyDateTime_IMPORT failu…
13da12b 
…re (pythonGH-24333)

Importing datetime can fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pganssle Awaiting requested review from pganssle
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL