FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43163: Handle unclosed parentheses in codeop by pablogsal · Pull Request #24483 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-43163: Handle unclosed parentheses in codeop - #24483

Merged
pablogsal merged 3 commits into
python:masterfrom
pablogsal:bpo-43163
Feb 9, 2021
ConversationCommits (3)ChecksFiles changed
Merged

bpo-43163: Handle unclosed parentheses in codeop#24483
pablogsal merged 3 commits into
python:masterfrom
pablogsal:bpo-43163

Conversation

pablogsal commented Feb 8, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal requested a review from terryjreedy February 8, 2021 23:03

pablogsal commented Feb 8, 2021

Copy link
Copy Markdown
Member Author

@terryjreedy please, feel free to suggest any new tests that you think it would be good to cover regarding this issue.

terryjreedy requested changes Feb 9, 2021
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I verified that this works from IDLE. Looks good but I would like the suggested change.

Comment thread Lib/codeop.py
Comment thread Lib/codeop.py Outdated

bedevere-bot commented Feb 9, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Update Lib/codeop.py
eaa7a03 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
pablogsal commented Feb 9, 2021
View reviewed changes
Comment thread Lib/codeop.py Outdated
pablogsal commented Feb 9, 2021
View reviewed changes
Comment thread Lib/codeop.py
pablogsal merged commit dbb2281 into python:master Feb 9, 2021

terryjreedy commented Feb 9, 2021

Copy link
Copy Markdown
Member

I though about additional tests and tried some things, which all passed, but I don't think any of them would be useful additions. For further testing, I might locally install Hypotheses and the associated random code generator and them run compile_command with valid, incomplete (snipped valid multiline code), and maybe invalid samples.

pablogsal deleted the bpo-43163 branch February 9, 2021 22:18
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-43163: Handle unclosed parentheses in codeop (pythonGH-24483)
6f17567
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL