FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython by nw0 · Pull Request #24550 · python/cpython · GitHub

/ cpython Public

bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython - #24550

Merged
vstinner merged 2 commits into
python:masterfrom
nw0:bpo-35134-1
Feb 17, 2021
ConversationCommits (2)ChecksFiles changed
Merged

bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython#24550
vstinner merged 2 commits into
python:masterfrom
nw0:bpo-35134-1

Conversation

nw0 commented Feb 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Move non-limited C API headers pyarena.h, pyctype.h into
Include/cpython.

In the same vein as previous PRs by @vstinner.

https://bugs.python.org/issue35134

Move Include/{pyarena.h,pyctype.h} to Include/cpython
ba11be5 
Move non-limited C API headers pyarena.h, pyctype.h into
Include/cpython.
nw0 requested review from a team, lysnikolaou and pablogsal as code owners February 16, 2021 14:13
pablogsal requested a review from vstinner February 16, 2021 14:16

vstinner commented Feb 16, 2021

Copy link
Copy Markdown
Member

Can you please add a NEWS entry in the C API to mention that pytime.h, pyarena.h and pyctype.h headers were moved into the cpython/ directory and must not be included directly: they are already included by Python.h.

You can add a :ref:`Include Files <api-includes>` link to https://docs.python.org/dev/c-api/intro.html#include-files.

nw0 commented Feb 17, 2021

Copy link
Copy Markdown
Contributor Author

Can you please add a NEWS entry in the C API to mention that pytime.h, pyarena.h and pyctype.h headers were moved into the cpython/ directory and must not be included directly: they are already included by Python.h.

You can add a :ref:`Include Files <api-includes>` link to https://docs.python.org/dev/c-api/intro.html#include-files.

Updated. Thanks for your review!

vstinner merged commit 366dc3a into python:master Feb 17, 2021

vstinner commented Feb 17, 2021

Copy link
Copy Markdown
Member

Merged, thanks!

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython/ (py…
3953750 
…thonGH-24550)

Move non-limited C API headers pyarena.h and pyctype.h
into Include/cpython/ directory.
vstinner mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lysnikolaou Awaiting requested review from lysnikolaou
pablogsal Awaiting requested review from pablogsal
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL