FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40642: use file-relative include for initconfig.h in pystate.h by xry111 · Pull Request #24744 · python/cpython · GitHub

Repository navigation

bpo-40642: use file-relative include for initconfig.h in pystate.h - #24744

Closed
xry111 wants to merge 1 commit into
python:masterfrom
xry111:bpo-40642
Closed

xry111 wants to merge 1 commit into
python:masterfrom
xry111:bpo-40642

Conversation

xry111 commented Mar 4, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Suggested by Andrew Tomazos in bpo:

This will mean that state.h will find initconfig.h using a file-relative include (as all the other include directives do), instead of relying on the installed Include directory being put in the header search path.

As this include directive is the only one with this property, the benefit of this change would be that the Include folder would be able to be installed in any subdirectory of a search path, rather than requiring its own dedicated one.

This would mean (for example) you could install different versions of the Python headers side by side and then select between them using preprocessor directives - rather than having to switch up global compiler options.

https://bugs.python.org/issue40642

xry111 marked this pull request as ready for review March 4, 2021 10:49

xry111 commented Apr 3, 2021

Copy link
Copy Markdown
Contributor Author

ping.

xry111 commented Apr 21, 2021

Copy link
Copy Markdown
Contributor Author

Closing, as this is a dup of #20181 and already nack'ed.

xry111 closed this Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL