bpo-43372: Use _freeze_importlib for regen-frozen. - #24759
Conversation
Sorry, something went wrong.
This approach ensures the code matches the interpreter version. Previously, PYTHON_FOR_REGEN was used to generate the code, which might be wrong. The marshal format for code objects has changed with bpo-42246, commit 877df85. Update the code and the expected code sizes in ctypes test_frozentable.
| 0,0,122,14,60,102,114,111,122,101,110,32,104,101,108,108, | ||
| 111,62,218,8,60,109,111,100,117,108,101,62,1,0,0,0, | ||
| 115,6,0,0,0,4,0,12,1,255,128, | ||
| }; |
There was a problem hiding this comment.
I don't understand why the file is suddenly so different when in the previous pull requests, only one line was updated.
Sorry, something went wrong.
There was a problem hiding this comment.
I think it's because the co_filename has changed. _freeze_importlib sets it to "<frozen hello>". Previously it was set to "none".
Sorry, something went wrong.
There was a problem hiding this comment.
Oh, and _freeze_importlib line wraps the byte array a bit differently.
Sorry, something went wrong.
| 218,8,60,109,111,100,117,108,101,62,1,0,0, | ||
| 0,115,2,0,0,0,4,1, | ||
| /* Auto-generated by Programs/_freeze_importlib.c */ | ||
| const unsigned char _Py_M__hello[] = { |
There was a problem hiding this comment.
Not sure making this non-static is good. The _freeze_importlib could grow a command line option to make it static or non-static.
Sorry, something went wrong.
This approach ensures the code matches the interpreter version.
Previously, PYTHON_FOR_REGEN was used to generate the code, which might
be wrong. The marshal format for code objects has changed with
bpo-42246, commit 877df85. Update the code and the expected code sizes
in ctypes test_frozentable.
https://bugs.python.org/issue43372