Repository navigation
bpo-29585: Define PYTHONFRAMEWORK in PC/pyconfig.h - #2477
Merged
vstinner merged 3 commits intoJun 28, 2017
Merged
vstinner merged 3 commits into
vstinner merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Run "make patchcheck".
This was referenced Jun 28, 2017
Copy link
Copy Markdown
Member
Author
|
Crap. Tests fail on Windows: ======================================================================
FAIL: test_get_path (test.test_site.HelperFunctionsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\projects\cpython\lib\test\test_site.py", line 188, in test_get_path
sysconfig.get_path('purelib', os.name + '_user'))
AssertionError: 'C:\\Users\\appveyor\\AppData\\Roaming\\Python/Python37/site-packages' != 'C:\\Users\\appveyor\\AppData\\Roaming\\Python\\Python37\\site-packages'
- C:\Users\appveyor\AppData\Roaming\Python/Python37/site-packages
? ^ ^
+ C:\Users\appveyor\AppData\Roaming\Python\Python37\site-packages
? ^ ^
======================================================================
FAIL: test_s_option (test.test_site.HelperFunctionsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\projects\cpython\lib\test\test_site.py", line 195, in test_s_option
self.assertIn(usersite, sys.path)
AssertionError: 'C:\\Users\\appveyor\\AppData\\Roaming\\Python/Python37/site-packages' not found in ['', 'C:\\projects\\cpython\\PCbuild\\win32\\python37.zip', 'C:\\projects\\cpython\\DLLs', 'C:\\projects\\cpython\\lib', 'C:\\projects\\cpython\\PCbuild\\win32', 'C:\\projects\\cpython', 'C:\\projects\\cpython\\lib\\site-packages']
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This PR fixes a regression of the PR #136. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
thanks |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
You're welcome. I hesitated to just revert your PR to get more time to fix it, but at the end, I found a way to repair the Windows buildbots, so it's fine. Hey, don't forget our macOS buildbots which are also broken! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix also PC/pyconfig.h whitespaces: run "make patchcheck".