FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Doc: io: Remove "In-memory streams" section by methane · Pull Request #24927 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Doc: io: Remove "In-memory streams" section - #24927

Merged
methane merged 2 commits into
python:masterfrom
methane:doc-io
Mar 25, 2021
ConversationCommits (2)ChecksFiles changed
Merged

Doc: io: Remove "In-memory streams" section#24927
methane merged 2 commits into
python:masterfrom
methane:doc-io

Conversation

methane commented Mar 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

This section looks be misplaced. It was written in b530e14.

methane requested a review from pitrou March 18, 2021 22:30
pitrou requested changes Mar 20, 2021
View reviewed changes

pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The overview describes the three separate classes of IO: raw, buffered binary, and text. "In-memory streams" are not a fourth kind of IO, so they don't belong in the overview.

We may want to move them into the "Class hierarchy" section however.

bedevere-bot commented Mar 20, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

methane commented Mar 21, 2021

Copy link
Copy Markdown
Member Author

BytesIO is in "Buffered Streams" section (because it inherits BufferedIOBase), and StringIO is in "Text I/O" section.

May I just remove this "In-memory streams" section?

methane changed the title Doc: io: Move In-memory streams section into overview section. Doc: io: Remove "In-memory streams" section Mar 21, 2021
methane merged commit b045cda into python:master Mar 25, 2021
methane deleted the doc-io branch March 25, 2021 07:23

miss-islington commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

bedevere-bot commented Mar 25, 2021

Copy link
Copy Markdown

GH-25017 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2021
Doc: io: Remove "In-memory streams" section (pythonGH-24927)
808c087 
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>

bedevere-bot commented Mar 25, 2021

Copy link
Copy Markdown

GH-25018 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2021
Doc: io: Remove "In-memory streams" section (pythonGH-24927)
15b5fa3 
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this pull request Apr 1, 2021
Doc: io: Remove "In-memory streams" section (GH-24927)
4ea8b24 
(cherry picked from commit b045cda)
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this pull request Apr 1, 2021
Doc: io: Remove "In-memory streams" section (GH-24927)
244fa23 
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pitrou pitrou requested changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL