FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43570: Doc: Fix i18n issue with audit hooks. by JulienPalard · Pull Request #24945 · python/cpython · GitHub

Repository navigation

bpo-43570: Doc: Fix i18n issue with audit hooks. - #24945

Closed
JulienPalard wants to merge 1 commit into
python:mainfrom
JulienPalard:mdk/audithooks
Closed

JulienPalard wants to merge 1 commit into
python:mainfrom
JulienPalard:mdk/audithooks

Conversation

JulienPalard commented Mar 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

humitos commented Mar 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I wanted to confirm here that this patch makes the Spanish translation to work as well. I didn't dig too much on the HTML generated yet, but at least Sphinx finishes with no warning at all with this patch.

We found the same problem in our translation and we are tracking it at python/python-docs-es#1221

JulienPalard requested a review from zooba March 21, 2021 09:30

Copy link
Copy Markdown
Member Author

I tried running sphinx -b gettext with this patch and it correctly removes unused strings:

-#: library/sys.rst:1246
-msgid ""
-"Raises an :ref:`auditing event <auditing>` ``sys.setprofile`` with no "
-"arguments."
-msgstr ""
-"Lève un :ref:`évènement d'audit <auditing>` ``sys.setprofile`` sans "
-"arguments."
-
 #: library/sys.rst:1329
 msgid "The events have the following meaning:"
 msgstr "Les événements ont la signification suivante :"
@@ -2659,13 +2657,6 @@ msgstr ""
 "Pour plus d'informations sur les objets code et objets représentant une "
 "*frame* de la pile, consultez :ref:`types`."

-#: library/sys.rst:1380
-msgid ""
-"Raises an :ref:`auditing event <auditing>` ``sys.settrace`` with no "
-"arguments."
-msgstr ""
-"Lève un :ref:`évènement d'audit <auditing>` ``sys.settrace`` sans arguments."
-

zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure exactly what's wrong, but the non-customised text paragraphs are empty.

I'm looking at the HTML files attached to the docs check on this PR.

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

Copy link
Copy Markdown

Thanks for making the requested changes!

@zooba: please review the changes made to this pull request.

bedevere-bot requested a review from zooba April 13, 2021 15:50

Copy link
Copy Markdown
Member Author

@humitos would you please check if this new patch works for the spanish translation?

Copy link
Copy Markdown
Member Author

I diff -red before and after this patch and the HTML does not change.

And wow, I feel good, I understand my own patch (it was NOT the case for the previous one):

As we translate restructuredtext, the rawsource (1rst parameter of paragraph) is important for translators. Before the patch, it was always set to the pyspecific text, even if overloaded a few line later with the rst content, so we translators were only seeing the pyspecific text.

Copy link
Copy Markdown
Member Author

Gentle ping @zooba.

github-actions Bot commented Jun 3, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 3, 2021

Copy link
Copy Markdown
Member Author

I'm closing this as I want to see how #19470 will change all of this, before. I'll reopen if needed.

JulienPalard deleted the mdk/audithooks branch October 9, 2021 07:32
JulienPalard restored the mdk/audithooks branch October 9, 2021 07:32
JulienPalard deleted the mdk/audithooks branch October 9, 2021 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting change review skip issue skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL