bpo-43244: Add pycore_compile.h header file - #25000
Merged
vstinner merged 1 commit intoMar 23, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
requested review from
a team,
isidentical and
markshannon
as code owners
March 23, 2021 19:58
Copy link
Copy Markdown
Member
Author
|
I checked if the removed functions are used by the top PyPI 4000 projects: there is only typed_ast, the same one that I met in PR #24933. vstinner@apu$ ./search.sh PyAST_Compile 2021-02-18/graphene-federation-0.1.0.tar.gz vstinner@apu$ ./search.sh PyAST_CompileEx 2021-02-18/graphene-federation-0.1.0.tar.gz vstinner@apu$ ./search.sh PyAST_CompileObject 2021-02-18/graphene-federation-0.1.0.tar.gz vstinner@apu$ ./search.sh PyFuture_FromASTObject 2021-02-18/graphene-federation-0.1.0.tar.gz vstinner@apu$ ./search.sh PyFuture_FromAST 2021-02-18/typed_ast-1.4.2.tar.gz 2021-02-18/graphene-federation-0.1.0.tar.gz graphene-federation-0.1.0.tar.gz contains a virtual environment which contains a Python binary (which contains the symbols). It can be safely ignored. |
Sorry, something went wrong.
Remove the compiler functions using "struct _mod" type, because the public AST C API was removed: * PyAST_Compile() * PyAST_CompileEx() * PyAST_CompileObject() * PyFuture_FromAST() * PyFuture_FromASTObject() These functions were undocumented and excluded from the limited C API. Rename functions: * PyAST_CompileObject() => _PyAST_Compile() * PyFuture_FromASTObject() => _PyFuture_FromAST() Moreover, _PyFuture_FromAST() is no longer exported (replace PyAPI_FUNC() with extern). _PyAST_Compile() remains exported for test_peg_generator. Remove also compatibility functions: * PyAST_Compile() * PyAST_CompileEx() * PyFuture_FromAST()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the compiler functions using "struct _mod" type, because the
public AST C API was removed:
These functions were undocumented and excluded from the limited C API.
Rename functions:
Moreover, _PyFuture_FromAST() is no longer exported (replace
PyAPI_FUNC() with extern). _PyAST_Compile() remains exported for
test_peg_generator.
Remove also compatibility functions:
https://bugs.python.org/issue43244