FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43680: Remove undocumented io.OpenWrapper by vstinner · Pull Request #25114 · python/cpython · GitHub

/ cpython Public

bpo-43680: Remove undocumented io.OpenWrapper - #25114

Closed
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:remove_open_wrapper
ConversationCommits (1)ChecksFiles changed
Closed

bpo-43680: Remove undocumented io.OpenWrapper#25114
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:remove_open_wrapper

Conversation

vstinner commented Mar 31, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Remove the undocumented io.OpenWrapper and _pyio.OpenWrapper
functions which could be used directly to define a method:
staticmethod(open) should now be used instead.

https://bugs.python.org/issue43680

bpo-43680: Remove undocumented io.OpenWrapper
83792e5 
Remove the undocumented io.OpenWrapper and _pyio.OpenWrapper
functions which could be used directly to define a method:
staticmethod(open) should now be used instead.
serhiy-storchaka reviewed Mar 31, 2021
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst
(Contributed by Yurii Karabas, Andrew Svetlov, Yury Selivanov and Kyle Stanley
in :issue:`42392`.)

* Remove the undocumented ``io.OpenWrapper`` and ``_pyio.OpenWrapper``

serhiy-storchaka Mar 31, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OpenWrapper itself is not purposed to be used in user code. The main effect is that it changes builtin open if Python implementation is used. It can affect PyPy or other implementations.

vstinner Mar 31, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

_pyio is supposed to be a drop-in replacement for the io module, whereas _pyio.open and io.open behave differently.

See https://bugs.python.org/issue43682 which would make it possible to use _pyio.open as a method, rather than having to go through OpenWrapper.

Nadzkielegit approved these changes Apr 4, 2021
View reviewed changes

Nadzkielegit left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doc/whatsnew/3.10.rst

vstinner commented Apr 13, 2021

Copy link
Copy Markdown
Member Author

I wrote PR #25357 to only deprecate the class, rather than removing it.

vstinner closed this Apr 13, 2021
vstinner deleted the remove_open_wrapper branch April 13, 2021 14:18
bedevere-app Bot mentioned this pull request Nov 6, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
+1 more reviewer
Nadzkielegit Nadzkielegit approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL