FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c. by shihai1991 · Pull Request #25115 · python/cpython · GitHub

/ cpython Public

bpo-41111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c. - #25115

Closed
shihai1991 wants to merge 2 commits into
python:masterfrom
shihai1991:bpo_41111
ConversationCommits (2)ChecksFiles changed
Closed

bpo-41111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c.#25115
shihai1991 wants to merge 2 commits into
python:masterfrom
shihai1991:bpo_41111

Conversation

shihai1991 commented Mar 31, 2021 •
edited by vstinner
Loading

Copy link
Copy Markdown
Member

shihai1991 changed the title bpo-4111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c. bpo-41111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c. Mar 31, 2021
shihai1991 closed this Mar 31, 2021
shihai1991 reopened this Mar 31, 2021
shihai1991 requested a review from vstinner April 1, 2021 01:00
shihai1991 requested a review from a team as a code owner April 1, 2021 15:36
vstinner reviewed Apr 2, 2021
View reviewed changes
Comment thread setup.py
define_macros=[('WITH_Py_LIMITED_API', 1)]))
else:
# Debug mode: Build xxlimited with the full API
# (which is compatible with the limited one)

vstinner Apr 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hum, I'm disappointed that CPython doesn't even support its own stable ABI in debug mode. So I created https://bugs.python.org/issue43688 to also support the limited C API in debug mode.

Comment thread Modules/xxlimited.c Outdated

/* xxlimited with the limited API. */
#ifdef WITH_Py_LIMITED_API
# define Py_LIMITED_API 0x03100000

vstinner Apr 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

0x03100000 is wrong: it must be 0x030a0000 (the bug exists in the current code). I fixed the issue in my PR #25131.

vstinner commented Apr 2, 2021

Copy link
Copy Markdown
Member

Oops. I forgot to publish my review. In the meanwhile, I fixed both issues in https://bugs.python.org/issue43688.

I created a new PR: PR #25151.

vstinner commented Apr 2, 2021

Copy link
Copy Markdown
Member

I merged PR #25151 instead, I marked you as a co-author of my change ;-)

vstinner closed this Apr 2, 2021
vstinner mentioned this pull request Nov 3, 2022
Closed
vstinner mentioned this pull request May 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL