FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43725: Add CI step to check changes in the exported ABI by pablogsal · Pull Request #25188 · python/cpython · GitHub

/ cpython Public

bpo-43725: Add CI step to check changes in the exported ABI - #25188

Closed
pablogsal wants to merge 1 commit into
python:masterfrom
pablogsal:abicheck
ConversationCommits (1)ChecksFiles changed
Closed

bpo-43725: Add CI step to check changes in the exported ABI#25188
pablogsal wants to merge 1 commit into
python:masterfrom
pablogsal:abicheck

Conversation

pablogsal commented Apr 4, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal changed the title Add CI step to check changes in the exported ABI bpo-43725: Add CI step to check changes in the exported ABI Apr 4, 2021
pablogsal force-pushed the abicheck branch 6 times, most recently from 311b675 to 953b0f1 Compare April 4, 2021 20:55

pablogsal commented Apr 4, 2021

Copy link
Copy Markdown
Member Author

Unfortunately seems that doing this check with two different compiler versions produce some different DWARF and the tool identifies the differences as errors :(

pablogsal closed this Apr 4, 2021
gpshead approved these changes Apr 4, 2021
View reviewed changes

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Neat, lets try it out! I suppose this shows up as a non-blocking check by default? Release branch owners can presumably decide if this is reliable enough to make it blocking.

pablogsal reopened this Apr 4, 2021

pablogsal commented Apr 4, 2021

Copy link
Copy Markdown
Member Author

I will try to investigate how to overcome this:

Unfortunately seems that doing this check with two different compiler versions produce some different DWARF and the tool identifies the differences as errors :(

pablogsal commented Apr 4, 2021

Copy link
Copy Markdown
Member Author

@gpshead Check my message in https://bugs.python.org/msg390213 with the analysis of this solution.

erlend-aasland reviewed Apr 4, 2021
View reviewed changes
Comment thread .github/workflows/build.yml

check_abi:
name: 'Check if the ABI has changed'
runs-on: ubuntu-latest

erlend-aasland Apr 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd pin the runner, to ensure that the job runs with at least the same major GCC version every time. Ref. bpo-43382.

pablogsal closed this Apr 6, 2021
pablogsal deleted the abicheck branch May 19, 2021 18:57
gpshead mentioned this pull request May 23, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland left review comments
gpshead gpshead approved these changes

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL