bpo-42998: add 'user' parameter to pathlib.Path.home() - #25271
Closed
barneygale wants to merge 3 commits into
Closed
bpo-42998: add 'user' parameter to pathlib.Path.home()#25271barneygale wants to merge 3 commits into
barneygale wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Needs tests and NEWS. |
Sorry, something went wrong.
barneygale
marked this pull request as ready for review
April 8, 2021 20:57
Copy link
Copy Markdown
Contributor
Author
|
Pretty sure the test failure is unrelated to my changes. |
Sorry, something went wrong.
Slightly re-arrange the internals such that `expanduser()` calls `home()`. This is to aid with the creation of an `AbstractPath` class in bpo-24132, where `cwd()` and `home()` will be abstract methods, but not `absolute()` or `expanduser()`.
barneygale
force-pushed
the
bpo-42998-pathlib-home-username-parameter
branch
from
42a44e6 to
43e7456
Compare
April 24, 2021 21:32
Copy link
Copy Markdown
Contributor
Author
|
Closing this PR, as it looks like resolving other users' home directories isn't something we can rely on! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also slightly re-arrange the internals such that expanduser() calls home().
This is to aid with the creation of an AbstractPath class in bpo-24132,
where cwd() and home() will be abstract methods, but not absolute()
or expanduser().
https://bugs.python.org/issue42998