FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.8] bpo-41100: Support macOS 11 and Apple Silicon by maxbelanger · Pull Request #25274 · python/cpython · GitHub

/ cpython Public

[3.8] bpo-41100: Support macOS 11 and Apple Silicon - #25274

Closed
maxbelanger wants to merge 3 commits into
python:3.8from
maxbelanger:mac-arm64-py38
Closed

[3.8] bpo-41100: Support macOS 11 and Apple Silicon#25274
maxbelanger wants to merge 3 commits into
python:3.8from
maxbelanger:mac-arm64-py38

Conversation

maxbelanger commented Apr 8, 2021
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This is a partial backport of bpo-41100 changes e8b1c038b14b5fc8120aab62c9bf5fb840274cb6 and 96d906b144e6e6aa96c5ffebecbcc5d38034bbda for Python 3.8. We introduce the ability to build Python from source for arm64 on macOS, but we do not make a promise of support. This allows us to omit support for weak-linking of symbols from the macOS SDK based on the deployment target, which are larger changes much more difficult to merge.

This also includes a backport of subsequent bpo-42688 change 7e729978fa08a360cbf936dc215ba7dd25a06a08 to fix build errors with external libffi.

https://bugs.python.org/issue41100

This is a partial backport of bpo-41100 changes `e8b1c038b14b5fc8120aab62c9bf5fb840274cb6` and `96d906b144e6e6aa96c5ffebecbcc5d38034bbda` for Python 3.8. We introduce the ability to build Python from source for `arm64` on macOS, but we do not make a promise of support. This allows us to omit support for Universal2 binaries as well as weak-linking of symbols from the macOS SDK based on the deployment target, which are larger changes much more difficult to merge.

This also includes a backport of subsequent bpo-42688 change `7e729978fa08a360cbf936dc215ba7dd25a06a08` to fix build errors with external `libffi`.
Comment thread Lib/_osx_support.py
Comment on lines +514 to +515
elif archs == ('arm64', 'x86_64'):
machine = 'universal2'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@ronaldoussoren I'm uncertain whether I should leave in the changes to allow universal2? I don't believe Homebrew requires this, nor would we (Dropbox).

I also don't think universal2 would be very practical given I am not back porting the weak linking changes.

ambv commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

We have less than a week to merge this before 3.8 goes into security fixes only mode.

ned-deily self-assigned this Apr 28, 2021

ned-deily commented May 2, 2021
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Thanks, @maxbelanger! As noted in bpo-41100, the contents of this PR have been rolled up into #25806. When that PR is resolved, we can close this one.

ambv closed this May 2, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for getting this over the finish line, @ned-deily!

maxbelanger deleted the mac-arm64-py38 branch May 2, 2021 19:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL