[3.9] bpo-43284: Update platform.win32_ver to use _syscmd_ver instead of sys.getwindowsversion() (GH-25500) - #25523
Merged
zooba merged 1 commit intoApr 23, 2021
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…s.getwindowsversion() (pythonGH-25500) The sys module uses the kernel32.dll version number, which can vary from the "actual" Windows version. Since the best option for getting the version is WMI (which is expensive), we switch back to launching cmd.exe (which is also expensive, but a lot less code on our part). sys.getwindowsversion() is not updated to avoid launching executables from that module. (cherry picked from commit 2a3f489) Co-authored-by: Shreyan Avigyan <shreyan.avigyan@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
@shreyanavigyan and @zooba: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@shreyanavigyan and @zooba: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
Author
|
@shreyanavigyan and @zooba: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
zooba
approved these changes
Apr 22, 2021
Copy link
Copy Markdown
Contributor
Author
|
@shreyanavigyan and @zooba: Status check is done, and it's a failure ❌ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
tkinter tests on Linux are not affected by this - guessing it's flakey. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sys module uses the kernel32.dll version number, which can vary from the "actual" Windows version.
Since the best option for getting the version is WMI (which is expensive), we switch back to launching cmd.exe (which is also expensive, but a lot less code on our part).
sys.getwindowsversion() is not updated to avoid launching executables from that module.
(cherry picked from commit 2a3f489)
Co-authored-by: Shreyan Avigyan shreyan.avigyan@gmail.com
https://bugs.python.org/issue43284