FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Feature/replace list comp with generator by zkneupper · Pull Request #26046 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Feature/replace list comp with generator - #26046

Closed
zkneupper wants to merge 8 commits into
python:mainfrom
zkneupper:feature/replace_list_comp_with_generator
ConversationCommits (8)ChecksFiles changed
Closed

Feature/replace list comp with generator#26046
zkneupper wants to merge 8 commits into
python:mainfrom
zkneupper:feature/replace_list_comp_with_generator

Conversation

zkneupper commented May 11, 2021

Copy link
Copy Markdown
Contributor

Replace list comprehensions with generator expressions inside str.join()

  • Replace list comprehensions with generator expressions inside str.join() in several places in Lib/_pydecimal.py and Lib/argparse.py
  • Replace a for loop with generator expression in Lib/ast.py

the-knights-who-say-ni commented May 11, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@zkneupper

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

erlend-aasland commented May 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi, and thank you for your interest in making CPython faster. Unfortunately, these changes are de-optimisations; list comprehensions are faster than generators. See Serhiy's review comment in #25798 (comment)

isidentical requested changes May 12, 2021
View reviewed changes

isidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is making the code look worse for the _pad_whitespace. Thanks for the contribution (are these automated?) though please refrain from posting this kind of changes in the future for the different parts of the codebase. If you know a potential improvement, open an issue and send a PR for that issue only.

bedevere-bot commented May 12, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

isidentical isidentical requested changes
rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL