bpo-44165: optimise sqlite3 statement preparation by passing string size - #26206
Merged
pablogsal merged 5 commits intoJun 2, 2021
Merged
bpo-44165: optimise sqlite3 statement preparation by passing string size#26206pablogsal merged 5 commits into
pablogsal merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@pablogsal I recon this can pass as skip news. This is an internal micro-optimisation only. No user visible change. |
Sorry, something went wrong.
pablogsal
reviewed
May 19, 2021
Comment thread
Modules/_sqlite/statement.c
Outdated
pablogsal
reviewed
May 19, 2021
Comment thread
Modules/_sqlite/cursor.c
Outdated
erlend-aasland
force-pushed
the
sqlite-prepare
branch
from
f3657ac to
9febd15
Compare
May 19, 2021 20:28
pablogsal
approved these changes
Jun 2, 2021
pablogsal
reviewed
Jun 2, 2021
Comment thread
Modules/_sqlite/cursor.c
pablogsal
reviewed
Jun 2, 2021
Comment thread
Modules/_sqlite/statement.c
Copy link
Copy Markdown
Contributor
Author
|
This PR was broken by fffa0f9. I'll resolve the issues in a new PR. |
Sorry, something went wrong.
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
Jun 2, 2021
pablogsal
pushed a commit
that referenced
this pull request
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoting the SQLite docs, https://sqlite.org/c3ref/prepare.html:
"If the caller knows that the supplied string is nul-terminated, then
there is a small performance advantage to passing an nByte parameter
that is the number of bytes in the input string including the
nul-terminator."
https://bugs.python.org/issue44165