FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix typo for configure.ac by corona10 · Pull Request #26305 · python/cpython · GitHub

/ cpython Public

Fix typo for configure.ac - #26305

Merged
corona10 merged 1 commit into
python:mainfrom
corona10:configure_typo
May 21, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Fix typo for configure.ac#26305
corona10 merged 1 commit into
python:mainfrom
corona10:configure_typo

Conversation

corona10 commented May 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

From #26078

corona10 requested a review from ned-deily May 21, 2021 22:34
corona10 changed the title Fix typo for configure.ac [WIP] Fix typo for configure.ac May 21, 2021
corona10 force-pushed the configure_typo branch 2 times, most recently from bf2c4f0 to ffe5d41 Compare May 21, 2021 22:50
ned-deily requested changes May 21, 2021
View reviewed changes

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks like there is a difference between the autoconf version you are using and the one last used to merge. As noted in configure.ac, we are using 2.69 but there are newer versions out there. Since this is truly a one-line change, I suggest you forget about trying autoreconf for this and just make that change manually :)

bedevere-bot commented May 21, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

corona10 commented May 21, 2021

Copy link
Copy Markdown
Member Author

I suggest you forget about trying autoreconf for this and just make that change manually :)

Got it

corona10 changed the title [WIP] Fix typo for configure.ac Fix typo for configure.ac May 21, 2021

corona10 commented May 21, 2021

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

bedevere-bot commented May 21, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

bedevere-bot requested a review from ned-deily May 21, 2021 22:56
ned-deily approved these changes May 21, 2021
View reviewed changes

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Sorry about all the churn.

corona10 commented May 21, 2021

Copy link
Copy Markdown
Member Author

Thank you @ned-deily
And sorry about my uncareful mistake.

corona10 merged commit a9e4361 into python:main May 21, 2021
corona10 deleted the configure_typo branch May 21, 2021 23:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

willingc willingc approved these changes
ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL