bpo-43908: Make heap types converted during 3.10 alpha immutable - #26351
Merged
pablogsal merged 20 commits intoJun 17, 2021
Merged
bpo-43908: Make heap types converted during 3.10 alpha immutable#26351pablogsal merged 20 commits into
pablogsal merged 20 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
added 17 commits
May 25, 2021 12:35
Copy link
Copy Markdown
Contributor
Author
|
I'll add tests in separate PRs. |
Sorry, something went wrong.
rhettinger
removed their request for review
May 31, 2021 19:36
Copy link
Copy Markdown
Contributor
Author
|
@vstinner Do you want me to break this up in multiple PR's? The number of files changed is high, but the actual diff is pretty short (+61 −38). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@vstinner Can you review this by Thursday, as this is a release blocker for beta 3? |
Sorry, something went wrong.
pablogsal
approved these changes
Jun 17, 2021
Copy link
Copy Markdown
Contributor
|
Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 17, 2021
…honGH-26351) * Make functools types immutable * Multibyte codec types are now immutable * pyexpat.xmlparser is now immutable * array.arrayiterator is now immutable * _thread types are now immutable * _csv types are now immutable * _queue.SimpleQueue is now immutable * mmap.mmap is now immutable * unicodedata.UCD is now immutable * sqlite3 types are now immutable * _lsprof.Profiler is now immutable * _overlapped.Overlapped is now immutable * _operator types are now immutable * winapi__overlapped.Overlapped is now immutable * _lzma types are now immutable * _bz2 types are now immutable * _dbm.dbm and _gdbm.gdbm are now immutable (cherry picked from commit 00710e6) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Copy link
Copy Markdown
|
GH-26766 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
pablogsal
pushed a commit
that referenced
this pull request
Jun 17, 2021
…26351) (GH-26766) * Make functools types immutable * Multibyte codec types are now immutable * pyexpat.xmlparser is now immutable * array.arrayiterator is now immutable * _thread types are now immutable * _csv types are now immutable * _queue.SimpleQueue is now immutable * mmap.mmap is now immutable * unicodedata.UCD is now immutable * sqlite3 types are now immutable * _lsprof.Profiler is now immutable * _overlapped.Overlapped is now immutable * _operator types are now immutable * winapi__overlapped.Overlapped is now immutable * _lzma types are now immutable * _bz2 types are now immutable * _dbm.dbm and _gdbm.gdbm are now immutable (cherry picked from commit 00710e6) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no> Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
jdevries3133
pushed a commit
to jdevries3133/cpython
that referenced
this pull request
Jun 19, 2021
…honGH-26351) * Make functools types immutable * Multibyte codec types are now immutable * pyexpat.xmlparser is now immutable * array.arrayiterator is now immutable * _thread types are now immutable * _csv types are now immutable * _queue.SimpleQueue is now immutable * mmap.mmap is now immutable * unicodedata.UCD is now immutable * sqlite3 types are now immutable * _lsprof.Profiler is now immutable * _overlapped.Overlapped is now immutable * _operator types are now immutable * winapi__overlapped.Overlapped is now immutable * _lzma types are now immutable * _bz2 types are now immutable * _dbm.dbm and _gdbm.gdbm are now immutable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43908