FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) by miss-islington · Pull Request #26411 · python/cpython · GitHub

/ cpython Public

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) - #26411

Closed
miss-islington wants to merge 1 commit into
python:3.10from
miss-islington:backport-fba42d1-3.10
ConversationCommits (1)ChecksFiles changed
Closed

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368)#26411
miss-islington wants to merge 1 commit into
python:3.10from
miss-islington:backport-fba42d1-3.10

Conversation

miss-islington commented May 27, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue42972

bpo-42972: Fully implement GC protocol for re types (pythonGH-26368)
e269fa1 
(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

bedevere-bot mentioned this pull request May 27, 2021
Merged

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

vstinner approved these changes May 27, 2021
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, good bot.

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a failure ❌ .

vstinner commented May 27, 2021

Copy link
Copy Markdown
Member

Tests / Windows (x64) (pull_request) Failing

It failed because of: https://bugs.python.org/issue44252#msg394581

I re-run the job.

vstinner closed this May 27, 2021
miss-islington deleted the backport-fba42d1-3.10 branch May 27, 2021 21:57

vstinner commented May 27, 2021

Copy link
Copy Markdown
Member

Problem 2: I had to cancel the Ubuntu job after 1 hour since downloading the ccache never completed.

Problem 3: I cannot re-run all jobs, the GitHub UI only offers me [cancel workflow] choice. I closed the PR, I will recreate it instead. Let's hope that https://bugs.python.org/issue44252#msg394581 doesn't occur again.

vstinner mentioned this pull request Jun 9, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL