bpo-43916: Use test.support.check_disallow_instantiation in test_tcl - #26412
Merged
vstinner merged 1 commit intoMay 27, 2021
Merged
bpo-43916: Use test.support.check_disallow_instantiation in test_tcl#26412vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
From issue 43988: Serhiy suggested to write an unit test for curses.ncurses_version: > https://bugs.python.org/issue43916#msg391936 Excerpt from msg391936: I think it is better to add tests for different modules in corresponding module test files. They are pretty trivial, for example:
def test_new_tcl_obj(self):
self.assertRaises(TypeError, _tkinter.Tcl_Obj)
@requires_curses_func('panel')
def test_new_curses_panel(self):
w = curses.newwin(10, 10)
panel = curses.panel.new_panel(w)
self.assertRaises(TypeError, type(panel))
test_new_curses_panel was added in GH-25748 and then converted to use the support helper in GH-26392. I'm not sure if it makes sense to add a test for curses.ncurses_version. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merged, thanks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @erlend-aasland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2021
pythonGH-26412) (cherry picked from commit e90e042) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Copy link
Copy Markdown
|
GH-26888 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43916