| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Please remove the [asyncio] prefix from the title. |
Sorry, something went wrong.
|
Ok |
Sorry, something went wrong.
|
I'm not sure that this issue solves MultiLoopChildWatcher design issue. The MultiLoopChildWatcher doc says that it can be used even if no event loop runs in the main thread, whereas add_signal_handler() must be called from the main thread: https://docs.python.org/dev/library/asyncio-eventloop.html#asyncio.loop.add_signal_handler |
Sorry, something went wrong.
This PR changes MultiLoopChildWatcher in a way that it still doesn't require a running loop in the main thread. So the basic idea remains the same. The only change is that MultiLoopChildWatcher now can't be used from any other thread. I've tested it in the REPL and also the test ran for about 30 minutes, so I guess this patch works? |
Sorry, something went wrong.
|
Breaking backwards compatibility is not an option for 3.9. I'd say the same for 3.10, since we're past feature freeze; beta phase is all about fixing regressions (and potentially ripping out newly introduced features). |
Sorry, something went wrong.
For 3.9, I agree. But since this is a bug wouldn't it be better to fix it in 3.10 beta? |
Sorry, something went wrong.
|
IMO, it's better to deprecate the class in 3.10 and remove it in 3.12, and for 3.9 do nothing. But, like Victor, I'm not an asyncio user, nor do I have any knowledge of that module, so my opinion does not really matter here. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
MultiLoopChildWatcher is deprecated now and the issue is closed so closing. Thanks. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fix a race condition in MultiLoopChildWatcher. This patch does the following -
This patch changes the behavior of MultiLoopChildWatcher. The original idea remains the same but with this patch MultiLoopChildWatcher can only be used in the main thread.
https://bugs.python.org/issue38323