FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-44396: Update multi-line-start location when reallocating tokenizer buffers by pablogsal · Pull Request #26676 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-44396: Update multi-line-start location when reallocating tokenizer buffers - #26676

Merged
miss-islington merged 1 commit into
python:mainfrom
pablogsal:bpo-44396
Jun 12, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-44396: Update multi-line-start location when reallocating tokenizer buffers#26676
miss-islington merged 1 commit into
python:mainfrom
pablogsal:bpo-44396

Conversation

pablogsal commented Jun 11, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue44396

Automerge-Triggered-By: GH:pablogsal

pablogsal requested a review from lysnikolaou as a code owner June 11, 2021 17:18

isidentical commented Jun 11, 2021

Copy link
Copy Markdown
Member

Should we also check whether multiline_start is NULL in

cpython/Parser/tokenizer.c

Line 1885 in 4cb6ba1

if (c == EOF || (quote_size == 1 && c == '\n')) {

pablogsal commented Jun 11, 2021

Copy link
Copy Markdown
Member Author

Should we also check whether multiline_start is NULL in

Hummm...why you think that is necessary? How can that happen?

isidentical commented Jun 11, 2021

Copy link
Copy Markdown
Member

If I am not missing anything, according to this (on your branch) when the tok->multi_line_start - tok->buf < 0, then multi_line_start becomes NULL.
https://github.com/python/cpython/blob/304ca6ddb0591405ca422b5442306b59b157e2ca/Parser/tokenizer.c#L388

isidentical approved these changes Jun 12, 2021
View reviewed changes

isidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

miss-islington commented Jun 12, 2021

Copy link
Copy Markdown
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

miss-islington merged commit a342cc5 into python:main Jun 12, 2021

miss-islington commented Jun 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot commented Jun 12, 2021

Copy link
Copy Markdown

GH-26695 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2021
bpo-44396: Update multi-line-start location when reallocating tokeniz…
b09e865 
…er buffers (pythonGH-26676)

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit a342cc5)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal deleted the bpo-44396 branch June 12, 2021 17:54
pablogsal pushed a commit that referenced this pull request Jun 12, 2021
bpo-44396: Update multi-line-start location when reallocating tokeniz…
d03f342 
…er buffers (GH-26676) (GH-26695)

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit a342cc5)
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
bpo-44396: Update multi-line-start location when reallocating tokeniz…
b1e8a39 
…er buffers (pythonGH-26676)

Automerge-Triggered-By: GH:pablogsal
pablogsal mentioned this pull request Jul 18, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

isidentical isidentical approved these changes
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL