FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43475: Fix the Python implementation of hash of Decimal NaN by serhiy-storchaka · Pull Request #26679 · python/cpython · GitHub

/ cpython Public

bpo-43475: Fix the Python implementation of hash of Decimal NaN - #26679

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:hash-nan
Jun 12, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-43475: Fix the Python implementation of hash of Decimal NaN#26679
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:hash-nan

Conversation

serhiy-storchaka commented Jun 11, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added type-bug An unexpected behavior, bug, or error skip news labels Jun 11, 2021
serhiy-storchaka commented Jun 11, 2021
View reviewed changes
Comment thread Lib/test/test_decimal.py
self.assertEqual(hashit(value), hashit(int(value)))

#the same hash that to an int
self.assertEqual(hashit(Decimal(23)), hashit(23))

serhiy-storchaka Jun 11, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Covered by tests above.

Comment thread Lib/test/test_decimal.py
Comment on lines -1822 to -1823
self.assertTrue(hashit(Decimal('Inf')))
self.assertTrue(hashit(Decimal('-Inf')))

serhiy-storchaka Jun 11, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Covered by tests below.

Comment thread Lib/test/test_decimal.py

#the same hash that to an int
self.assertEqual(hashit(Decimal(23)), hashit(23))
self.assertRaises(TypeError, hash, Decimal('sNaN'))

serhiy-storchaka Jun 11, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Moved to test_hash_method_nan.

mdickinson approved these changes Jun 12, 2021
View reviewed changes

mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

serhiy-storchaka merged commit 9f1c5f6 into python:main Jun 12, 2021
serhiy-storchaka deleted the hash-nan branch June 12, 2021 12:15
serhiy-storchaka added the needs backport to 3.10 only security fixes label Jun 13, 2021

miss-islington commented Jun 13, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot commented Jun 13, 2021

Copy link
Copy Markdown

GH-26706 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 13, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2021
bpo-43475: Fix the Python implementation of hash of Decimal NaN (pyth…
ed58970 
…onGH-26679)

(cherry picked from commit 9f1c5f6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jun 13, 2021
bpo-43475: Fix the Python implementation of hash of Decimal NaN (GH-2…
128899d 
…6679)

(cherry picked from commit 9f1c5f6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
bpo-43475: Fix the Python implementation of hash of Decimal NaN (pyth…
29584b7 
…onGH-26679)
pablogsal mentioned this pull request Jul 18, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhettinger Awaiting requested review from rhettinger
1 more reviewer
mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL