FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag by erlend-aasland · Pull Request #26680 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag - #26680

Merged
nanjekyejoannah merged 1 commit into
python:mainfrom
erlend-aasland:remove-duplicate-ssl-flag
Jun 12, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag#26680
nanjekyejoannah merged 1 commit into
python:mainfrom
erlend-aasland:remove-duplicate-ssl-flag

Conversation

erlend-aasland commented Jun 11, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland requested a review from tiran June 11, 2021 18:43
nanjekyejoannah approved these changes Jun 12, 2021
View reviewed changes

nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks okay to me, @tiran can confirm on this.

erlend-aasland commented Jun 12, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @nanjekyejoannah! I figure this is just a copy-and-paste error.

nanjekyejoannah reviewed Jun 12, 2021
View reviewed changes

nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree, let me merge this. Christian can complain, if it was not meant to be.

nanjekyejoannah merged commit cb7230c into python:main Jun 12, 2021
erlend-aasland deleted the remove-duplicate-ssl-flag branch June 12, 2021 20:18

miss-islington commented Jun 13, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2021
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (pythonGH-26680)
82a43de 
(cherry picked from commit cb7230c)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented Jun 13, 2021

Copy link
Copy Markdown

GH-26704 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Jun 13, 2021
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (GH-26680)
f30f484 
(cherry picked from commit cb7230c)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (pythonGH-26680)
732ecab
pablogsal mentioned this pull request Jul 18, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nanjekyejoannah nanjekyejoannah approved these changes
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL