Speed up test_urlsplit_normalization - #26688
Merged
serhiy-storchaka merged 1 commit intoJul 22, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
corona10
reviewed
Jun 21, 2021
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, something went wrong.
corona10
reviewed
Jun 21, 2021
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@serhiy-storchaka
I think that this PR is worth to review :) Can you please take a look?
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Jul 22, 2021
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Jul 22, 2021
Speed up test_urlsplit_normalization (pythonGH-26688)
Copy link
Copy Markdown
Member
|
Thank you for your contribution @jacobtylerwalls. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while working on #26687 that one of the tests in test_urlparse took ~7s. Here I've short-circuited the filtering of a massive list comprehension (sys.maxunicode for me is 1,114,111) by checking if not empty before running split(), set(), &, etc.
LMK if this needs a ticket.
$ ./python.exe -m unittest test.test_urlparse.UrlParseTestCase.test_urlsplit_normalization
Before
Ran 1 test in 6.981s
After
Ran 1 test in 2.459s