| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
|
Why did you close this? The CLA? For spelling corrections, we merely prefer the CLA, but don't need it, as the change is from a 'creative' misspelling to the dictionary standard. You cannot copyright the correct spelling. I will apply this, but hope you go ahead and sign it now so you are ready for a future PR. The initial Pipelines failure? It is a build failure, which should be unrelated to the PR and should be transient. |
Sorry, something went wrong.
|
@terryjreedy Hi. Thanks for your reply. I am new. That means a lot to me. Thanks again for your time! |
Sorry, something went wrong.
|
Reverting configure.ac did not work, so I made sure updated to latest main. |
Sorry, something went wrong.
|
@terryjreedy - be careful with this one, I spotted some changes that weren't good. |
Sorry, something went wrong.
|
@cjw296 Please be specific. A couple of hours ago I reviewed carefully and already reverted, corrected, or checked everything I though questionable. |
Sorry, something went wrong.
|
@cjw296 I recheck and found this: in ssl.py, 'woth' should by 'with', not 'worth'. Fixed. I think others looks good in context. |
Sorry, something went wrong.
|
Bin-bin, If you (or anyone else) are on Linux and can run 'make regen-all' and commet whatever that changes, please try that. |
Sorry, something went wrong.
There was a problem hiding this comment.
I'm not on Linux right now, so I can't help with 'make regen-all', sorry.
But all of the corrections look good to me. Thanks, @enjoy-binbin and @terryjreedy.
Sorry, something went wrong.
|
@terryjreedy It seems that re-gen was ok. I was trying to solve that one half hour ago. Sorry for that, i didn't expect to cause this problem... and others minor fix |
Sorry, something went wrong.
|
On corementorship, Guido said how to rebuild on windows: PCbuild\build -r. importlib_external.h was rebuilt, followed by errors that disappeared on rerun. I will redo the the misspellings I reverted and is that does not create a problem, merge. |
Sorry, something went wrong.
|
Thanks @enjoy-binbin for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, something went wrong.
|
Sorry, @enjoy-binbin and @terryjreedy, I could not cleanly backport this to 3.10 due to a conflict. |
Sorry, something went wrong.
|
Yes, more time than expected. At least I learned that rebuilding can be done on Windows. I have seen the make message before and assumed I had to have a make system. Another core def suggested that the error message should be more informative. I expected that auto backport would fail even though most of these misspelling either originated with or were backported at least to 3.10. If you do a 3.10 backport that passes tests , I will review and merge. Using the cherry_picker module is easier than git cherry-picker as it automates more. Whether and how are up to you. |
Sorry, something went wrong.
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>. (cherry picked from commit 17b16e1) Co-authored-by: Binbin <binloveplay1314@qq.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
| Back | FazBrowse Home | New Git URL |
Correct minor spelling typos