| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
A TypeError is now raised instead of an AttributeError in "with" and "async with" statements for objects which do not support the context manager or asynchronous context manager protocols correspondingly.
There was a problem hiding this comment.
I support the idea.
For the code, why not pass the message format string to special_lookup() instead of repeating the same code four times?
Also I think it would be useful to know which attribute is missing.
Sorry, something went wrong.
It would save 3 lines in every of 4 caller places, but the helper function adds 14 lines. Also, I think that in future we can add slots for these methods, this will make the common code so simple that there will be nothing to share.
I think that in most cases the error is in using wrong object rather than missing of some dunder methods in the definition of user class. Traditional error messages: >>> len(1) TypeError: object of type 'int' has no len() >>> list(1) TypeError: 'int' object is not iterable It does not say "requires an object with __iter__ method". But it may be worth to add a hint in case of the object that has __enter__ but not __exit__. It is definitely an error in the user class definition. |
Sorry, something went wrong.
There was a problem hiding this comment.
Okay, LG then!
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
A TypeError is now raised instead of an AttributeError in
"with" and "async with" statements for objects which do not
support the context manager or asynchronous context manager
protocols correspondingly.
https://bugs.python.org/issue12022