Repository navigation
bpo-42892: fix email multipart attribute error - #26903
Merged
ambv merged 8 commits intoJul 30, 2021
Merged
ambv merged 8 commits into
ambv merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
iritkatriel
reviewed
Jun 27, 2021
Comment thread
Lib/test/test_email/test_message.py
Outdated
Comment thread
Lib/test/test_email/test_message.py
Outdated
…m:akulakov/cpython into 42892-Fix-email-multipart-attribute-error
Copy link
Copy Markdown
Contributor
Author
|
@iritkatriel I pushed an update, please take a look.. note the test failure is unrelated to the PR (it says that grammar.new file is missing). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM, but would be good if @bitdancer also had a look. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@iritkatriel thanks for the review :) |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2021
(cherry picked from commit e3f877c) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Copy link
Copy Markdown
|
GH-27492 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2021
(cherry picked from commit e3f877c) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Copy link
Copy Markdown
|
GH-27493 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
ambv
pushed a commit
that referenced
this pull request
Jul 30, 2021
ambv
pushed a commit
that referenced
this pull request
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the patch by @bitdancer in the ticket.
Unit test updates by Andrei K.
https://bugs.python.org/issue42892