FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43950: Print columns in tracebacks (PEP 657) by ammaraskar · Pull Request #26958 · python/cpython · GitHub

/ cpython Public

bpo-43950: Print columns in tracebacks (PEP 657) - #26958

Merged
pablogsal merged 5 commits into
python:mainfrom
colnotab:codeobject_changes
Jul 4, 2021
ConversationCommits (5)ChecksFiles changed
Merged

bpo-43950: Print columns in tracebacks (PEP 657)#26958
pablogsal merged 5 commits into
python:mainfrom
colnotab:codeobject_changes

Conversation

ammaraskar commented Jun 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

This pull request implements the relevant bits in traceback printing to utilize the new co_positions and PyCode_Addr2... APIs to print carets for column locations.

All the internal structures, and data representation are subjected to change in future PRs as we add optimizations.

https://bugs.python.org/issue43950

ammaraskar force-pushed the codeobject_changes branch 8 times, most recently from d69a6a4 to 6d4302d Compare July 2, 2021 01:44
ammaraskar changed the title bpo-43950: Make compiler output more source offsets. bpo-43950: Print columns in tracebacks (PEP 657) Jul 2, 2021
ammaraskar mentioned this pull request Jul 2, 2021
Merged

pablogsal commented Jul 2, 2021

Copy link
Copy Markdown
Member

@ammaraskar Ground control to major tom, commencing countdown engines on

Rebase time!

isidentical reviewed Jul 2, 2021
View reviewed changes
Comment thread Python/traceback.c Outdated
isidentical reviewed Jul 2, 2021
View reviewed changes
Comment thread Python/traceback.c Outdated
pablogsal marked this pull request as ready for review July 2, 2021 14:21
pablogsal force-pushed the codeobject_changes branch from 6d4302d to 1fd558c Compare July 2, 2021 14:21
isidentical reviewed Jul 4, 2021
View reviewed changes
Comment thread Python/traceback.c Outdated
isidentical reviewed Jul 4, 2021
View reviewed changes
Comment thread Python/traceback.c Outdated
isidentical reviewed Jul 4, 2021
View reviewed changes
Comment thread Python/traceback.c Outdated
isidentical reviewed Jul 4, 2021
View reviewed changes
Comment thread Python/traceback.c

pablogsal commented Jul 4, 2021

Copy link
Copy Markdown
Member

@pablogsal would you mind cleaning up the byte_to_character_offset_in_line function here.

Yeah, I will do that. Could you address first @isidentical feedback?

ammaraskar mentioned this pull request Jul 4, 2021
Merged
ammaraskar force-pushed the codeobject_changes branch from 73bcea3 to 9a31711 Compare July 4, 2021 19:59
pablogsal force-pushed the codeobject_changes branch 6 times, most recently from e0b1f4b to 58e2f7f Compare July 4, 2021 22:24
pablogsal merged commit 5644c7b into python:main Jul 4, 2021
pablogsal deleted the codeobject_changes branch July 4, 2021 23:14

pablogsal commented Jul 5, 2021

Copy link
Copy Markdown
Member

@ammaraskar Can you open the prs for the follow-ups?

#26958 (comment)

ammaraskar commented Jul 5, 2021

Copy link
Copy Markdown
Member Author

#27023 for the config change, working on the traceback.py refactor + a bpo issue.

ammaraskar commented Jul 5, 2021

Copy link
Copy Markdown
Member Author

https://bugs.python.org/issue44569 for the traceback.py change, PR for it coming soon.

pablogsal mentioned this pull request Apr 13, 2022
Closed
hroncok mentioned this pull request Jun 18, 2022
Merged
graingert reviewed Nov 2, 2022
View reviewed changes
Comment thread Lib/traceback.py
"""
if f is None:
f = sys._getframe().f_back.f_back
f = sys._getframe().f_back.f_back.f_back.f_back

graingert Nov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this doesn't seem correct -

Python 3.11.0 | packaged by conda-forge | (main, Oct 25 2022, 06:18:27) [GCC 10.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import traceback
>>> traceback.walk_stack(None)
<generator object walk_stack at 0x7f308f4c4700>
>>> list(traceback.walk_stack(None))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/graingert/anaconda3/envs/dask-distributed-311/lib/python3.11/traceback.py", line 332, in walk_stack
    f = sys._getframe().f_back.f_back.f_back.f_back
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'f_back'
>>>

pablogsal Nov 2, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please, don't comment on merged pull requests because they are not monitored and you risk no one looking at your comment. Always open a new issue :)

graingert mentioned this pull request Nov 2, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

graingert graingert left review comments
pablogsal pablogsal approved these changes
isidentical isidentical left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL