Repository navigation
bpo-43425: Update setup.py not to use distutils.log - #26969
corona10 merged 3 commits into
Conversation
Sorry, something went wrong.
|
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11 contains in names |
Sorry, something went wrong.
| else: | ||
| newfilename = filename + minoronly | ||
| log.info('renaming %s to %s', filename, newfilename) | ||
| log.info(f'renaming {filename} to {newfilename}') |
There was a problem hiding this comment.
With your change, I no longer see this message. IMO you should mimick distutils setup() function which sets the logging thredshold to INFO:
File "/home/vstinner/python/main/./setup.py", line 2698, in main
setup(# PyPI Metadata (PEP 301)
File "/home/vstinner/python/main/Lib/distutils/core.py", line 134, in setup
ok = dist.parse_command_line()
File "/home/vstinner/python/main/Lib/distutils/dist.py", line 477, in parse_command_line
log.set_verbosity(self.verbose)
File "/home/vstinner/python/main/Lib/distutils/log.py", line 78, in set_verbosity
set_threshold(INFO)
To see the message on the main branch:
$ rm -rf build/scripts-3.11/ $ make (...) renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11 renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11 renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11
Sorry, something went wrong.
There was a problem hiding this comment.
Thank's nice catch :)
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
Ok, this time I can ready "renaming ..." logs ;-)
Sorry, something went wrong.
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, something went wrong.
(cherry picked from commit a7e251b) Co-authored-by: Dong-hee Na <donghee.na@python.org>
|
GH-26986 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
https://bugs.python.org/issue43425