FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43950: optimize column table assembling with pre-sizing the column table by isidentical · Pull Request #26997 · python/cpython · GitHub

/ cpython Public

bpo-43950: optimize column table assembling with pre-sizing the column table - #26997

Merged
miss-islington merged 1 commit into
python:mainfrom
isidentical:optimize-co-positions
Jul 2, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-43950: optimize column table assembling with pre-sizing the column table#26997
miss-islington merged 1 commit into
python:mainfrom
isidentical:optimize-co-positions

Conversation

isidentical commented Jul 2, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

The new resizing system works like this;

$ cat t.py
a + a + a + b + c + a + a + a + b + c + a + a + a + b + c + a + a + a + b + c
[repeated 99 more times]
$ ./python t.py
RESIZE: prev len = 32, new len = 66
FINAL SIZE: 56
-----------------------------------------------------
RESIZE: prev len = 32, new len = 66
RESIZE: prev len = 66, new len = 134
RESIZE: prev len = 134, new len = 270
RESIZE: prev len = 270, new len = 542
RESIZE: prev len = 542, new len = 1086
RESIZE: prev len = 1086, new len = 2174
RESIZE: prev len = 2174, new len = 4350
RESIZE: prev len = 4350, new len = 8702
FINAL SIZE: 8004

So now we do considerably lower number of _PyBytes_Resize calls.

https://bugs.python.org/issue43950

Automerge-Triggered-By: GH:isidentical

isidentical requested a review from markshannon as a code owner July 2, 2021 17:34
pablogsal approved these changes Jul 2, 2021
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I can confirm that this speeds up the allocation quite a lot as expected 👍

❯ time ./python -m test test_compile -m test_stack_overflow -v
== CPython 3.11.0a0 (heads/optimize-co-positions:760daf9858, Jul 2 2021, 19:08:05) [GCC 11.1.0]
== Linux-5.12.13-arch1-2-x86_64-with-glibc2.33 little-endian
== cwd: /home/pablogsal/github/python/main/build/test_python_15988æ
== CPU count: 36
== encodings: locale=UTF-8, FS=utf-8
0:00:00 load avg: 2.15 Run tests sequentially
0:00:00 load avg: 2.15 [1/1] test_compile
test_stack_overflow (test.test_compile.TestSpecifics) ... ok

----------------------------------------------------------------------

Ran 1 test in 3.945s

OK

== Tests result: SUCCESS ==

1 test OK.

Total duration: 4.0 sec
Tests result: SUCCESS
./python -m test test_compile -m test_stack_overflow -v  3.77s user 0.47s system 99% cpu 4.241 total

miss-islington commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

@isidentical: Status check is done, and it's a success ❌ .

isidentical commented Jul 2, 2021

Copy link
Copy Markdown
Member Author

concurrent_futures error, irrelevant, restarting the CI

miss-islington commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

@isidentical: Status check is done, and it's a success ✅ .

miss-islington commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 3 of 5 required status checks have not succeeded: 2 expected..

miss-islington commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

@isidentical: Status check is done, and it's a success ✅ .

miss-islington merged commit ec8759b into python:main Jul 2, 2021
isidentical changed the title bpo-43950: optimize column table assembling with pre-sizing object bpo-43950: optimize column table assembling with pre-sizing the column table Jul 3, 2021
pablogsal mentioned this pull request Apr 13, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL