FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-38291: Fix a spurious warning when using help(object) by srittau · Pull Request #27039 · python/cpython · GitHub

/ cpython Public

bpo-38291: Fix a spurious warning when using help(object) - #27039

Merged
gvanrossum merged 2 commits into
python:mainfrom
srittau:typing-io
Jul 6, 2021
ConversationCommits (2)ChecksFiles changed
Merged

bpo-38291: Fix a spurious warning when using help(object)#27039
gvanrossum merged 2 commits into
python:mainfrom
srittau:typing-io

Conversation

srittau commented Jul 5, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue38291

Automerge-Triggered-By: GH:gvanrossum

Fix a spurious warning when using help(object)
8900c2d 
help(object) via pydoc.TextDoc.docclass(object) iterates over the
subclasses of object, which includes typing.io and typing.re if typing
is imported. It tries to access cls.__module__ for each of those
sub-classes. This change suppresses warnings when accessing
cls.__module__.

srittau commented Jul 5, 2021

Copy link
Copy Markdown
Contributor Author

This should not need a NEWS entry per:

These are the two exceptions:

  1. [...]
  2. If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed.

srittau commented Jul 5, 2021

Copy link
Copy Markdown
Contributor Author

The Azure build failure seems unrelated.

gvanrossum reviewed Jul 6, 2021
View reviewed changes
Comment thread Lib/typing.py Outdated

miss-islington commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@srittau: Status check is done, and it's a success ❌ .

srittau commented Jul 6, 2021

Copy link
Copy Markdown
Contributor Author

This time, Azure passes, but the address sanitizer(?) test times out. Looks like an unrelated multiprocessing error, possibly a race condition.

gvanrossum commented Jul 6, 2021

Copy link
Copy Markdown
Member

Alas, we have to close and reopen the PR to make the last test pass (hopefully), GitHub won't let me merge without that.

gvanrossum closed this Jul 6, 2021
gvanrossum reopened this Jul 6, 2021

miss-islington commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@srittau: Status check is done, and it's a success ❌ .

2 similar comments

miss-islington commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@srittau: Status check is done, and it's a success ❌ .

miss-islington commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@srittau: Status check is done, and it's a success ❌ .

gvanrossum merged commit 8b849ea into python:main Jul 6, 2021

bedevere-bot commented Jul 6, 2021

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

gvanrossum commented Jul 6, 2021

Copy link
Copy Markdown
Member

Is a backport needed?

srittau deleted the typing-io branch July 6, 2021 15:27

srittau commented Jul 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks and no backport needed, the original change is just in the 3.11 branch trunk.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL