FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41255: handle argparse errors with exit_on_error=False consistently by joshmeranda · Pull Request #27295 · python/cpython · GitHub

/ cpython Public

bpo-41255: handle argparse errors with exit_on_error=False consistently - #27295

Closed
joshmeranda wants to merge 4 commits into
python:mainfrom
joshmeranda:issue-41255
ConversationCommits (4)ChecksFiles changed
Closed

bpo-41255: handle argparse errors with exit_on_error=False consistently#27295
joshmeranda wants to merge 4 commits into
python:mainfrom
joshmeranda:issue-41255

Conversation

joshmeranda commented Jul 22, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

bpo-41255

When unknown arguments are passed to parse_args or required arguments not passed to either parse_args or parse_known_args argpase exits despite exit_on_error=False. This is not very intuitive, instead any error parsing arguments should result in an ArgumentError which can be handled by the user.

https://bugs.python.org/issue41255

the-knights-who-say-ni commented Jul 22, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@joshmeranda

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

github-actions Bot commented Aug 27, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 27, 2021
jacobtylerwalls mentioned this pull request Feb 5, 2022
Closed
MaxwellDupre approved these changes Mar 14, 2022
View reviewed changes

MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Works for me:
Ran 1658 tests in 2.516s
OK

Simple bug mentioned case too!
Nice work

matthewhughes934 mannequin mentioned this pull request Apr 10, 2022
Closed
AA-Turner closed this Jun 7, 2022
AA-Turner reopened this Jun 7, 2022

AA-Turner commented Jun 7, 2022

Copy link
Copy Markdown
Member

Trigger CLA.

A

AA-Turner added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory and removed CLA signed stale Stale PR or inactive for long period of time. labels Jun 7, 2022

github-actions Bot commented Aug 11, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 11, 2022

serhiy-storchaka commented Jun 28, 2024

Copy link
Copy Markdown
Member

Thank you for your contribution @joshmeranda. I apologize for the fact that this PR was neglected for a long time. The problem has already been solved in another way.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time. stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL